diff options
| author | bors <bors@rust-lang.org> | 2016-02-01 07:06:05 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2016-02-01 07:06:05 +0000 |
| commit | 14dc9fcc672b904245bc41732b5ca9a4f24436da (patch) | |
| tree | a408ea4bf84a0d43d695dbdeec69c5bcd417a38f | |
| parent | 654f68dd50b72d1d812b0760f1b71d7c366f6f55 (diff) | |
| parent | 641267e4c20edda3e7b96c58547542e245af5553 (diff) | |
| download | rust-14dc9fcc672b904245bc41732b5ca9a4f24436da.tar.gz rust-14dc9fcc672b904245bc41732b5ca9a4f24436da.zip | |
Auto merge of #31232 - stepancheg:enum-univariant, r=nrc
```
enum Univariant {
X = 17
}
```
Fixes #10292
| -rw-r--r-- | src/librustc_typeck/check/mod.rs | 11 | ||||
| -rw-r--r-- | src/librustc_typeck/diagnostics.rs | 7 | ||||
| -rw-r--r-- | src/test/run-pass/enum-univariant-repr.rs | 47 |
3 files changed, 50 insertions, 15 deletions
diff --git a/src/librustc_typeck/check/mod.rs b/src/librustc_typeck/check/mod.rs index af343e0b079..f811eb872fc 100644 --- a/src/librustc_typeck/check/mod.rs +++ b/src/librustc_typeck/check/mod.rs @@ -4250,14 +4250,9 @@ pub fn check_enum_variants<'a,'tcx>(ccx: &CrateCtxt<'a,'tcx>, let def_id = ccx.tcx.map.local_def_id(id); let hint = *ccx.tcx.lookup_repr_hints(def_id).get(0).unwrap_or(&attr::ReprAny); - if hint != attr::ReprAny && vs.len() <= 1 { - if vs.len() == 1 { - span_err!(ccx.tcx.sess, sp, E0083, - "unsupported representation for univariant enum"); - } else { - span_err!(ccx.tcx.sess, sp, E0084, - "unsupported representation for zero-variant enum"); - }; + if hint != attr::ReprAny && vs.is_empty() { + span_err!(ccx.tcx.sess, sp, E0084, + "unsupported representation for zero-variant enum"); } do_check(ccx, vs, id, hint); diff --git a/src/librustc_typeck/diagnostics.rs b/src/librustc_typeck/diagnostics.rs index 8f7692c7945..df09cd26134 100644 --- a/src/librustc_typeck/diagnostics.rs +++ b/src/librustc_typeck/diagnostics.rs @@ -1062,13 +1062,6 @@ Note also that without a representation manually defined, the compiler will optimize by using the smallest integer type possible. "##, -E0083: r##" -At present, it's not possible to define a custom representation for an enum with -a single variant. As a workaround you can add a `Dummy` variant. - -See: https://github.com/rust-lang/rust/issues/10292 -"##, - E0084: r##" It is impossible to define an integer type to be used to represent zero-variant enum values because there are no zero-variant enum values. There is no way to diff --git a/src/test/run-pass/enum-univariant-repr.rs b/src/test/run-pass/enum-univariant-repr.rs new file mode 100644 index 00000000000..ef4cc60bf0d --- /dev/null +++ b/src/test/run-pass/enum-univariant-repr.rs @@ -0,0 +1,47 @@ +// Copyright 2016 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or +// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license +// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + + +use std::mem; + +// Univariant C-like enum +#[repr(i32)] +enum Univariant { + X = 17 +} + +#[repr(u16)] +enum UnivariantWithoutDescr { + Y +} + +pub fn main() { + { + assert_eq!(4, mem::size_of::<Univariant>()); + assert_eq!(17, Univariant::X as i32); + + let enums: &[Univariant] = + &[Univariant::X, Univariant::X, Univariant::X]; + let ints: &[i32] = unsafe { mem::transmute(enums) }; + // check it has the same memory layout as i32 + assert_eq!(&[17, 17, 17], ints); + } + + { + assert_eq!(2, mem::size_of::<UnivariantWithoutDescr>()); + let descr = UnivariantWithoutDescr::Y as u16; + + let enums: &[UnivariantWithoutDescr] = + &[UnivariantWithoutDescr::Y, UnivariantWithoutDescr::Y, UnivariantWithoutDescr::Y]; + let ints: &[u16] = unsafe { mem::transmute(enums) }; + // check it has the same memory layout as u16 + assert_eq!(&[descr, descr, descr], ints); + } +} |
