about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAnders Kaseorg <andersk@mit.edu>2021-02-18 12:41:08 -0800
committerAnders Kaseorg <andersk@mit.edu>2021-02-18 12:42:45 -0800
commit1605af015c493c4800be9b56d7eb8d759f9a7d3c (patch)
tree094517016a5f10e11fc21e6f2e787f53a554dcd1
parentb05788e859d3d553825eb114f07573f4839286b1 (diff)
downloadrust-1605af015c493c4800be9b56d7eb8d759f9a7d3c.tar.gz
rust-1605af015c493c4800be9b56d7eb8d759f9a7d3c.zip
libtest: Fix unwrap panic on duplicate TestDesc.
It is possible for different tests to collide to the same TestDesc
when macros are involved.  That is a bug, but it didn’t cause a panic
until #81367.  For now, change the code to ignore this problem.

Fixes #81852.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
-rw-r--r--library/test/src/lib.rs13
1 files changed, 7 insertions, 6 deletions
diff --git a/library/test/src/lib.rs b/library/test/src/lib.rs
index 3ff79eaea49..2d37fdd135e 100644
--- a/library/test/src/lib.rs
+++ b/library/test/src/lib.rs
@@ -353,12 +353,13 @@ where
             }
 
             let mut completed_test = res.unwrap();
-            let running_test = running_tests.remove(&completed_test.desc).unwrap();
-            if let Some(join_handle) = running_test.join_handle {
-                if let Err(_) = join_handle.join() {
-                    if let TrOk = completed_test.result {
-                        completed_test.result =
-                            TrFailedMsg("panicked after reporting success".to_string());
+            if let Some(running_test) = running_tests.remove(&completed_test.desc) {
+                if let Some(join_handle) = running_test.join_handle {
+                    if let Err(_) = join_handle.join() {
+                        if let TrOk = completed_test.result {
+                            completed_test.result =
+                                TrFailedMsg("panicked after reporting success".to_string());
+                        }
                     }
                 }
             }