about summary refs log tree commit diff
diff options
context:
space:
mode:
authorvarkor <github@varkor.com>2018-05-11 21:36:24 +0100
committervarkor <github@varkor.com>2018-05-11 21:36:24 +0100
commit16c088d3254bf5fc75ae3ce9f498bfc522098db8 (patch)
tree2401ac0880c4831c9a2723b95637fb12287d6521
parentfd85de14599d0ad8bbe5750d2fa83b806b2dbc5e (diff)
downloadrust-16c088d3254bf5fc75ae3ce9f498bfc522098db8.tar.gz
rust-16c088d3254bf5fc75ae3ce9f498bfc522098db8.zip
Display the name of the failed file in tidy/libcoretest
-rw-r--r--src/tools/tidy/src/libcoretest.rs23
1 files changed, 15 insertions, 8 deletions
diff --git a/src/tools/tidy/src/libcoretest.rs b/src/tools/tidy/src/libcoretest.rs
index f6864c7f84e..363d01d964e 100644
--- a/src/tools/tidy/src/libcoretest.rs
+++ b/src/tools/tidy/src/libcoretest.rs
@@ -22,14 +22,21 @@ pub fn check(path: &Path, bad: &mut bool) {
         &libcore_path,
         &mut |subpath| t!(subpath.strip_prefix(&libcore_path)).starts_with("tests"),
         &mut |subpath| {
-            if subpath.ends_with(".rs") {
-                if t!(read_to_string(subpath)).contains("#[test]") {
-                    tidy_error!(
-                        bad,
-                        "{} contains #[test]; libcore tests must be placed inside \
-                        `src/libcore/tests/`",
-                        subpath.display()
-                    );
+            if let Some("rs") = subpath.extension().and_then(|e| e.to_str()) {
+                match read_to_string(subpath) {
+                    Ok(contents) => {
+                        if contents.contains("#[test]") {
+                            tidy_error!(
+                                bad,
+                                "{} contains #[test]; libcore tests must be placed inside \
+                                `src/libcore/tests/`",
+                                subpath.display()
+                            );
+                        }
+                    }
+                    Err(err) => {
+                        panic!("failed to read file {:?}: {}", subpath, err);
+                    }
                 }
             }
         },