diff options
| author | Ralf Jung <post@ralfj.de> | 2020-12-22 13:05:31 +0100 |
|---|---|---|
| committer | Ralf Jung <post@ralfj.de> | 2020-12-30 18:39:05 +0100 |
| commit | 1862135351e87905e7a497bee96f199040ce1b51 (patch) | |
| tree | 2659bb878af8ce4e063025a93c256bf22f282594 | |
| parent | bbcaed03bf5505f3fed351887769ed1531599502 (diff) | |
| download | rust-1862135351e87905e7a497bee96f199040ce1b51.tar.gz rust-1862135351e87905e7a497bee96f199040ce1b51.zip | |
implement ptr::write without dedicated intrinsic
| -rw-r--r-- | library/core/src/intrinsics.rs | 7 | ||||
| -rw-r--r-- | library/core/src/ptr/mod.rs | 16 |
2 files changed, 11 insertions, 12 deletions
diff --git a/library/core/src/intrinsics.rs b/library/core/src/intrinsics.rs index 87863ab5c68..0a537adba5a 100644 --- a/library/core/src/intrinsics.rs +++ b/library/core/src/intrinsics.rs @@ -768,13 +768,6 @@ extern "rust-intrinsic" { #[rustc_const_stable(feature = "const_size_of", since = "1.40.0")] pub fn size_of<T>() -> usize; - /// Moves a value to an uninitialized memory location. - /// - /// Drop glue is not run on the destination. - /// - /// The stabilized version of this intrinsic is [`core::ptr::write`](crate::ptr::write). - pub fn move_val_init<T>(dst: *mut T, src: T); - /// The minimum alignment of a type. /// /// The stabilized version of this intrinsic is [`core::mem::align_of`](crate::mem::align_of). diff --git a/library/core/src/ptr/mod.rs b/library/core/src/ptr/mod.rs index 807f114ea46..8fe10099bb9 100644 --- a/library/core/src/ptr/mod.rs +++ b/library/core/src/ptr/mod.rs @@ -883,12 +883,18 @@ pub const unsafe fn read_unaligned<T>(src: *const T) -> T { #[inline] #[stable(feature = "rust1", since = "1.0.0")] pub unsafe fn write<T>(dst: *mut T, src: T) { - if cfg!(debug_assertions) && !is_aligned_and_not_null(dst) { - // Not panicking to keep codegen impact smaller. - abort(); + // We are calling the intrinsics directly to avoid function calls in the generated code. + extern "rust-intrinsic" { + fn copy_nonoverlapping<T>(src: *const T, dst: *mut T, count: usize); + } + + // SAFETY: the caller must guarantee that `dst` is valid for writes. + // `dst` cannot overlap `src` because the caller has mutable access + // to `dst` while `src` is owned by this function. + unsafe { + copy_nonoverlapping(&src as *const T, dst, 1); + intrinsics::forget(src); } - // SAFETY: the caller must uphold the safety contract for `move_val_init`. - unsafe { intrinsics::move_val_init(&mut *dst, src) } } /// Overwrites a memory location with the given value without reading or |
