diff options
| author | Michael Sullivan <sully@msully.net> | 2013-07-11 14:34:10 -0700 |
|---|---|---|
| committer | Michael Sullivan <sully@msully.net> | 2013-07-11 15:51:10 -0700 |
| commit | 19446418bcc7ae48b23dd89d04e78c3d552e3001 (patch) | |
| tree | 6780fa8eafdd1b19db6fe8cb973ad8561b70cf4d | |
| parent | 186f6faf1e6f4b507d97fefcb02fd8a7cf8d716f (diff) | |
| download | rust-19446418bcc7ae48b23dd89d04e78c3d552e3001.tar.gz rust-19446418bcc7ae48b23dd89d04e78c3d552e3001.zip | |
Drop a now unnecessary argument from maybe_instantiate_inline.
| -rw-r--r-- | src/librustc/middle/trans/base.rs | 2 | ||||
| -rw-r--r-- | src/librustc/middle/trans/callee.rs | 3 | ||||
| -rw-r--r-- | src/librustc/middle/trans/consts.rs | 2 | ||||
| -rw-r--r-- | src/librustc/middle/trans/expr.rs | 2 | ||||
| -rw-r--r-- | src/librustc/middle/trans/inline.rs | 14 | ||||
| -rw-r--r-- | src/librustc/middle/trans/type_use.rs | 2 |
6 files changed, 10 insertions, 15 deletions
diff --git a/src/librustc/middle/trans/base.rs b/src/librustc/middle/trans/base.rs index 881264f57a4..b04f041618d 100644 --- a/src/librustc/middle/trans/base.rs +++ b/src/librustc/middle/trans/base.rs @@ -520,7 +520,7 @@ pub fn get_res_dtor(ccx: @mut CrateContext, let _icx = push_ctxt("trans_res_dtor"); if !substs.is_empty() { let did = if did.crate != ast::local_crate { - inline::maybe_instantiate_inline(ccx, did, true) + inline::maybe_instantiate_inline(ccx, did) } else { did }; diff --git a/src/librustc/middle/trans/callee.rs b/src/librustc/middle/trans/callee.rs index 948d3481fa0..01bd69f24fc 100644 --- a/src/librustc/middle/trans/callee.rs +++ b/src/librustc/middle/trans/callee.rs @@ -361,8 +361,7 @@ pub fn trans_fn_ref_with_vtables( // def_id to the local id of the inlined copy. let def_id = { if def_id.crate != ast::local_crate { - let may_translate = opt_impl_did.is_none(); - inline::maybe_instantiate_inline(ccx, def_id, may_translate) + inline::maybe_instantiate_inline(ccx, def_id) } else { def_id } diff --git a/src/librustc/middle/trans/consts.rs b/src/librustc/middle/trans/consts.rs index 9044ef57003..69c8331bc9f 100644 --- a/src/librustc/middle/trans/consts.rs +++ b/src/librustc/middle/trans/consts.rs @@ -159,7 +159,7 @@ pub fn get_const_val(cx: @mut CrateContext, mut def_id: ast::def_id) -> ValueRef let contains_key = cx.const_values.contains_key(&def_id.node); if !ast_util::is_local(def_id) || !contains_key { if !ast_util::is_local(def_id) { - def_id = inline::maybe_instantiate_inline(cx, def_id, true); + def_id = inline::maybe_instantiate_inline(cx, def_id); } match cx.tcx.items.get_copy(&def_id.node) { ast_map::node_item(@ast::item { diff --git a/src/librustc/middle/trans/expr.rs b/src/librustc/middle/trans/expr.rs index 19a0f7262ff..f1718b91e56 100644 --- a/src/librustc/middle/trans/expr.rs +++ b/src/librustc/middle/trans/expr.rs @@ -956,7 +956,7 @@ fn trans_lvalue_unadjusted(bcx: block, expr: @ast::expr) -> DatumBlock { fn get_did(ccx: @mut CrateContext, did: ast::def_id) -> ast::def_id { if did.crate != ast::local_crate { - inline::maybe_instantiate_inline(ccx, did, true) + inline::maybe_instantiate_inline(ccx, did) } else { did } diff --git a/src/librustc/middle/trans/inline.rs b/src/librustc/middle/trans/inline.rs index 1f7b2bd4663..e2d84473e23 100644 --- a/src/librustc/middle/trans/inline.rs +++ b/src/librustc/middle/trans/inline.rs @@ -22,11 +22,7 @@ use syntax::ast; use syntax::ast_map::path_name; use syntax::ast_util::local_def; -// `translate` will be true if this function is allowed to translate the -// item and false otherwise. Currently, this parameter is set to false when -// translating default methods. -pub fn maybe_instantiate_inline(ccx: @mut CrateContext, fn_id: ast::def_id, - translate: bool) +pub fn maybe_instantiate_inline(ccx: @mut CrateContext, fn_id: ast::def_id) -> ast::def_id { let _icx = push_ctxt("maybe_instantiate_inline"); match ccx.external.find(&fn_id) { @@ -59,7 +55,7 @@ pub fn maybe_instantiate_inline(ccx: @mut CrateContext, fn_id: ast::def_id, csearch::found(ast::ii_item(item)) => { ccx.external.insert(fn_id, Some(item.id)); ccx.stats.n_inlines += 1; - if translate { trans_item(ccx, item); } + trans_item(ccx, item); local_def(item.id) } csearch::found(ast::ii_foreign(item)) => { @@ -81,19 +77,19 @@ pub fn maybe_instantiate_inline(ccx: @mut CrateContext, fn_id: ast::def_id, _ => ccx.sess.bug("maybe_instantiate_inline: item has a \ non-enum parent") } - if translate { trans_item(ccx, item); } + trans_item(ccx, item); local_def(my_id) } csearch::found_parent(_, _) => { ccx.sess.bug("maybe_get_item_ast returned a found_parent \ with a non-item parent"); } - csearch::found(ast::ii_method(impl_did, _is_provided, mth)) => { + csearch::found(ast::ii_method(impl_did, is_provided, mth)) => { ccx.stats.n_inlines += 1; ccx.external.insert(fn_id, Some(mth.id)); // If this is a default method, we can't look up the // impl type. But we aren't going to translate anyways, so don't. - if !translate { return local_def(mth.id); } + if is_provided { return local_def(mth.id); } let impl_tpt = ty::lookup_item_type(ccx.tcx, impl_did); let num_type_params = diff --git a/src/librustc/middle/trans/type_use.rs b/src/librustc/middle/trans/type_use.rs index 505353bc535..eda8f853071 100644 --- a/src/librustc/middle/trans/type_use.rs +++ b/src/librustc/middle/trans/type_use.rs @@ -75,7 +75,7 @@ pub fn type_uses_for(ccx: @mut CrateContext, fn_id: def_id, n_tps: uint) let fn_id_loc = if fn_id.crate == local_crate { fn_id } else { - inline::maybe_instantiate_inline(ccx, fn_id, true) + inline::maybe_instantiate_inline(ccx, fn_id) }; // Conservatively assume full use for recursive loops |
