about summary refs log tree commit diff
diff options
context:
space:
mode:
authorYuki Okushi <huyuumi.dev@gmail.com>2020-03-01 19:28:05 +0900
committerGitHub <noreply@github.com>2020-03-01 19:28:05 +0900
commit1e258784e141d68737d5702c6f388bd340c1d889 (patch)
treebc7354fb77d308a5710a35c56e7126854706ef3f
parentd9051341a1c142542a3f7dab509266606c775382 (diff)
parent598b187e2738b5b551f84be30cc15503896fe4ba (diff)
downloadrust-1e258784e141d68737d5702c6f388bd340c1d889.tar.gz
rust-1e258784e141d68737d5702c6f388bd340c1d889.zip
Rollup merge of #69397 - tmiasko:llvm-version-suffix, r=nagisa
bootstrap: Remove commit hash from LLVM version suffix to avoid rebuilds

The custom LLVM version suffix was introduced to avoid unintentional
library names conflicts. By default it included the LLVM submodule
commit hash. Changing the version suffix requires the complete LLVM
rebuild, and since then every change to the submodules required it as
well.

Remove the commit hash from version suffix to avoid complete rebuilds,
while leaving the `rust` string, the release number and release channel
to disambiguate the library name.

Context: version suffix was introduced by #59173 as solution to #59034.

Resolves #68715.
-rw-r--r--src/bootstrap/native.rs8
1 files changed, 2 insertions, 6 deletions
diff --git a/src/bootstrap/native.rs b/src/bootstrap/native.rs
index 21dcb1d8aa0..c22c2a336f1 100644
--- a/src/bootstrap/native.rs
+++ b/src/bootstrap/native.rs
@@ -241,12 +241,8 @@ impl Step for Llvm {
                 cfg.define("LLVM_VERSION_SUFFIX", suffix);
             }
         } else {
-            let mut default_suffix =
-                format!("-rust-{}-{}", channel::CFG_RELEASE_NUM, builder.config.channel,);
-            if let Some(sha) = llvm_info.sha_short() {
-                default_suffix.push_str("-");
-                default_suffix.push_str(sha);
-            }
+            let default_suffix =
+                format!("-rust-{}-{}", channel::CFG_RELEASE_NUM, builder.config.channel);
             cfg.define("LLVM_VERSION_SUFFIX", default_suffix);
         }