about summary refs log tree commit diff
diff options
context:
space:
mode:
authorNikhil Shagrithaya <nikhilshagri@gmail.com>2016-07-15 20:47:45 +0530
committerNikhil Shagrithaya <nikhilshagri@gmail.com>2016-08-10 22:04:41 +0530
commit221000abbeb233edafff2a00b9b10c2d13f4ad05 (patch)
tree5f8337aac7fcc0a876ec486a32674c1855d621bf
parentae774103501337ed63b42b673c6c4fdbf369e80e (diff)
downloadrust-221000abbeb233edafff2a00b9b10c2d13f4ad05.tar.gz
rust-221000abbeb233edafff2a00b9b10c2d13f4ad05.zip
Refactored code to access TLS only in case of panic
-rw-r--r--src/libstd/panicking.rs20
1 files changed, 11 insertions, 9 deletions
diff --git a/src/libstd/panicking.rs b/src/libstd/panicking.rs
index 57a4c3df70a..4473e79a294 100644
--- a/src/libstd/panicking.rs
+++ b/src/libstd/panicking.rs
@@ -242,10 +242,9 @@ fn default_hook(info: &PanicInfo) {
 pub unsafe fn try<R, F: FnOnce() -> R>(f: F) -> Result<R, Box<Any + Send>> {
     let mut slot = None;
     let mut f = Some(f);
-    let ret = PANIC_COUNT.with(|s| {
-        let prev = s.get();
-        s.set(0);
+    let ret;
 
+    {
         let mut to_run = || {
             slot = Some(f.take().unwrap()());
         };
@@ -258,18 +257,21 @@ pub unsafe fn try<R, F: FnOnce() -> R>(f: F) -> Result<R, Box<Any + Send>> {
                                          dataptr,
                                          &mut any_data,
                                          &mut any_vtable);
-        s.set(prev);
-
         if r == 0 {
-            Ok(())
+            ret = Ok(());
         } else {
-            Err(mem::transmute(raw::TraitObject {
+            PANIC_COUNT.with(|s| {
+                let prev = s.get();
+                s.set(prev - 1);
+            });
+            ret = Err(mem::transmute(raw::TraitObject {
                 data: any_data as *mut _,
                 vtable: any_vtable as *mut _,
-            }))
+            }));
         }
-    });
+    }
 
+    debug_assert!(PANIC_COUNT.with(|c| c.get() == 0));
     return ret.map(|()| {
         slot.take().unwrap()
     });