diff options
| author | bors <bors@rust-lang.org> | 2024-11-17 13:19:56 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2024-11-17 13:19:56 +0000 |
| commit | 23e7ecb34962ecd069cf28ae7db585e92ca2ee63 (patch) | |
| tree | 5980dabe0c1dc654ec32e4a2c85d1f3e67b87d63 | |
| parent | 1e0df74445a185fc97b7e806cd6c636eaded1326 (diff) | |
| parent | 040929bc11041fb3ba34a5399edb16e2993f17e1 (diff) | |
| download | rust-23e7ecb34962ecd069cf28ae7db585e92ca2ee63.tar.gz rust-23e7ecb34962ecd069cf28ae7db585e92ca2ee63.zip | |
Auto merge of #125949 - erikdesjardins:nocomponent, r=jieyouxu
Revert "tidy: validate LLVM component names in tests" This reverts #125472. This has already caused a [bit](https://github.com/rust-lang/rust/pull/125702) of [trouble](https://github.com/rust-lang/rust/pull/125710), and I was mistaken about the original motivation--incorrect component names [_will_](https://github.com/rust-lang/rust/pull/125702#issuecomment-2137030731) be detected by a full CI run. I no longer think it pulls its weight. r? `@workingjubilee`
| -rw-r--r-- | src/tools/tidy/src/target_specific_tests.rs | 34 |
1 files changed, 0 insertions, 34 deletions
diff --git a/src/tools/tidy/src/target_specific_tests.rs b/src/tools/tidy/src/target_specific_tests.rs index 751d678e581..a66ccd37070 100644 --- a/src/tools/tidy/src/target_specific_tests.rs +++ b/src/tools/tidy/src/target_specific_tests.rs @@ -10,26 +10,6 @@ use crate::walk::filter_not_rust; const LLVM_COMPONENTS_HEADER: &str = "needs-llvm-components:"; const COMPILE_FLAGS_HEADER: &str = "compile-flags:"; -const KNOWN_LLVM_COMPONENTS: &[&str] = &[ - "aarch64", - "arm", - "avr", - "bpf", - "csky", - "hexagon", - "loongarch", - "m68k", - "mips", - "msp430", - "nvptx", - "powerpc", - "riscv", - "sparc", - "systemz", - "webassembly", - "x86", -]; - #[derive(Default, Debug)] struct RevisionInfo<'a> { target_arch: Option<&'a str>, @@ -94,20 +74,6 @@ pub fn check(tests_path: &Path, bad: &mut bool) { // gathered. } } - if let Some(llvm_components) = llvm_components { - for component in llvm_components { - // Ensure the given component even exists. - // This is somewhat redundant with COMPILETEST_REQUIRE_ALL_LLVM_COMPONENTS, - // but helps detect such problems earlier (PR CI rather than bors CI). - if !KNOWN_LLVM_COMPONENTS.contains(component) { - eprintln!( - "{}: revision {} specifies unknown LLVM component `{}`", - file, rev, component - ); - *bad = true; - } - } - } } }); } |
