about summary refs log tree commit diff
diff options
context:
space:
mode:
authorBrian Anderson <banderson@mozilla.com>2011-12-01 15:33:15 -0800
committerBrian Anderson <banderson@mozilla.com>2011-12-01 15:33:15 -0800
commit249f017bf2456100cabcfe5fcc2353097257fc84 (patch)
tree8e69dcee388e549e1e9406544008ddb4f5c7c171
parent6da1a3fcd6b8996a8fde2dd80a93a3a3008a9659 (diff)
rt: Add FIXME's about future changes to LLVM's __morestack impl
-rw-r--r--src/rt/arch/i386/morestack.S2
-rw-r--r--src/rt/rust_task.cpp3
2 files changed, 5 insertions, 0 deletions
diff --git a/src/rt/arch/i386/morestack.S b/src/rt/arch/i386/morestack.S
index 7162f859a72..4eb5f0c2d2a 100644
--- a/src/rt/arch/i386/morestack.S
+++ b/src/rt/arch/i386/morestack.S
@@ -19,6 +19,8 @@
 #define MORESTACK               __morestack
 #endif
 
+// FIXME: Future LLVM patches remove these 8 alignment bytes from
+// the function prologue in order to match gcc's behavior
 #define ALIGNMENT 8
 #define RETURN_OFFSET   7
 
diff --git a/src/rt/rust_task.cpp b/src/rt/rust_task.cpp
index 97e22618741..808d1a6b986 100644
--- a/src/rt/rust_task.cpp
+++ b/src/rt/rust_task.cpp
@@ -588,6 +588,9 @@ rust_task::del_stack() {
 
 void
 rust_task::record_stack_limit() {
+    // FIXME: Future LLVM patches expect us to add an additional 256 bytes
+    // here so that, if the frame size is < 256 it can generate the
+    // comparison against esp directly, instead of some offset from esp
     record_sp(stk->data + RED_ZONE_SIZE);
 }
 //