about summary refs log tree commit diff
diff options
context:
space:
mode:
authorNiko Matsakis <niko@alum.mit.edu>2017-11-07 05:54:31 -0500
committerNiko Matsakis <niko@alum.mit.edu>2017-11-16 05:57:50 -0500
commit267574c8dfce8c7e6cc910e18d280c278544df26 (patch)
treebbc2efb630477553a390e6f5b0117e26b4276503
parent013f88b9fb22496b8ec58b350447834edce6fc0e (diff)
downloadrust-267574c8dfce8c7e6cc910e18d280c278544df26.tar.gz
rust-267574c8dfce8c7e6cc910e18d280c278544df26.zip
convert TODO in traits into a FIXME
-rw-r--r--src/librustc/traits/mod.rs13
1 files changed, 8 insertions, 5 deletions
diff --git a/src/librustc/traits/mod.rs b/src/librustc/traits/mod.rs
index 0489a316cb3..9314c9d051d 100644
--- a/src/librustc/traits/mod.rs
+++ b/src/librustc/traits/mod.rs
@@ -538,11 +538,14 @@ pub fn normalize_param_env_or_error<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>,
         let region_scope_tree = region::ScopeTree::default();
         let free_regions = FreeRegionMap::new();
 
-        // TODO We should really... do something with these. But as of
-        // this writing we were ignoring them, just without knowing
-        // it, and it would take some refactoring to stop doing so.
-        // (In particular, the needed methods currently live in
-        // regionck.) -nmatsakis
+        // FIXME. We should really... do something with these region
+        // obligations. But this call just continues the older
+        // behavior (i.e., doesn't cause any new bugs), and it would
+        // take some further refactoring to actually solve them. In
+        // particular, we would have to handle implied bounds
+        // properly, and that code is currently largely confined to
+        // regionck (though I made some efforts to extract it
+        // out). -nmatsakis
         let _ = infcx.ignore_region_obligations(body_id);
 
         infcx.resolve_regions_and_report_errors(region_context, &region_scope_tree, &free_regions);