diff options
| author | Ralf Jung <post@ralfj.de> | 2024-05-08 19:11:17 +0200 |
|---|---|---|
| committer | Ralf Jung <post@ralfj.de> | 2024-05-08 19:11:17 +0200 |
| commit | 281aa50e3f52e13377444c518b190ac5dbace0cb (patch) | |
| tree | bb356911311925947ecd3e1170eae07f7697478b | |
| parent | e3029d220f6843f9b83d35927ff20a86137d7ed0 (diff) | |
| download | rust-281aa50e3f52e13377444c518b190ac5dbace0cb.tar.gz rust-281aa50e3f52e13377444c518b190ac5dbace0cb.zip | |
bootstrap: add comments for the automatic dry run
| -rw-r--r-- | src/bootstrap/src/core/builder.rs | 3 | ||||
| -rw-r--r-- | src/bootstrap/src/lib.rs | 2 |
2 files changed, 5 insertions, 0 deletions
diff --git a/src/bootstrap/src/core/builder.rs b/src/bootstrap/src/core/builder.rs index 6c4b26ec219..b206aadef62 100644 --- a/src/bootstrap/src/core/builder.rs +++ b/src/bootstrap/src/core/builder.rs @@ -88,6 +88,9 @@ pub trait Step: 'static + Clone + Debug + PartialEq + Eq + Hash { /// Primary function to execute this rule. Can call `builder.ensure()` /// with other steps to run those. + /// + /// This gets called twice during a normal `./x.py` execution: first + /// with `dry_run() == true`, and then for real. fn run(self, builder: &Builder<'_>) -> Self::Output; /// When bootstrap is passed a set of paths, this controls whether this rule diff --git a/src/bootstrap/src/lib.rs b/src/bootstrap/src/lib.rs index 47b03d411cb..c4420010f24 100644 --- a/src/bootstrap/src/lib.rs +++ b/src/bootstrap/src/lib.rs @@ -683,6 +683,8 @@ impl Build { if !self.config.dry_run() { { + // We first to a dry-run. This is a sanity-check to ensure that + // steps don't do anything expensive in the dry-run. self.config.dry_run = DryRun::SelfCheck; let builder = builder::Builder::new(self); builder.execute_cli(); |
