diff options
| author | Fabian Wolff <fabian.wolff@alumni.ethz.ch> | 2021-08-19 01:01:49 +0200 |
|---|---|---|
| committer | Fabian Wolff <fabian.wolff@alumni.ethz.ch> | 2021-08-19 01:01:49 +0200 |
| commit | 2884a74d083cc6d601e5f1e53cc33b60e9655cfc (patch) | |
| tree | 0c70f6df21e0d83b7515c529704eb5db0539d44c | |
| parent | 3d0774d0dc98084d25d95cc1909a8051ebbd9cb1 (diff) | |
| download | rust-2884a74d083cc6d601e5f1e53cc33b60e9655cfc.tar.gz rust-2884a74d083cc6d601e5f1e53cc33b60e9655cfc.zip | |
Fix non-capturing closure return type coercion
| -rw-r--r-- | compiler/rustc_typeck/src/check/coercion.rs | 4 | ||||
| -rw-r--r-- | src/test/ui/coercion/issue-88097.rs | 31 |
2 files changed, 35 insertions, 0 deletions
diff --git a/compiler/rustc_typeck/src/check/coercion.rs b/compiler/rustc_typeck/src/check/coercion.rs index 208eb27c844..e3c43aa8b84 100644 --- a/compiler/rustc_typeck/src/check/coercion.rs +++ b/compiler/rustc_typeck/src/check/coercion.rs @@ -941,6 +941,10 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { exprs.len() ); + if prev_ty == new_ty { + return Ok(prev_ty); + } + // Special-case that coercion alone cannot handle: // Function items or non-capturing closures of differing IDs or InternalSubsts. let (a_sig, b_sig) = { diff --git a/src/test/ui/coercion/issue-88097.rs b/src/test/ui/coercion/issue-88097.rs new file mode 100644 index 00000000000..e543e1bae92 --- /dev/null +++ b/src/test/ui/coercion/issue-88097.rs @@ -0,0 +1,31 @@ +// In #88097, the compiler attempted to coerce a closure type to itself via +// a function pointer, which caused an unnecessary error. Check that this +// behavior has been fixed. + +// check-pass + +fn peculiar() -> impl Fn(u8) -> u8 { + return |x| x + 1 +} + +fn peculiar2() -> impl Fn(u8) -> u8 { + return |x| x + 1; +} + +fn peculiar3() -> impl Fn(u8) -> u8 { + let f = |x| x + 1; + return f +} + +fn peculiar4() -> impl Fn(u8) -> u8 { + let f = |x| x + 1; + f +} + +fn peculiar5() -> impl Fn(u8) -> u8 { + let f = |x| x + 1; + let g = |x| x + 2; + return if true { f } else { g } +} + +fn main() {} |
