about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJoshua Nelson <jyn514@gmail.com>2021-05-17 22:07:30 -0400
committerJoshua Nelson <jyn514@gmail.com>2021-05-17 22:08:20 -0400
commit28c9c04325819662219340b21be55daf1d22ae4d (patch)
tree3ab125fe57cf127976abe097c76d35893edc0cc2
parent3e99439f4dacc8ba0d2ca48d221694362d587927 (diff)
downloadrust-28c9c04325819662219340b21be55daf1d22ae4d.tar.gz
rust-28c9c04325819662219340b21be55daf1d22ae4d.zip
Don't require cmake on Windows when LLVM isn't being built
Previously, setting `download-ci-llvm = true` when cmake wasn't
installed would give the following error:

```
failed to execute command: "cmake" "--help"
error: The system cannot find the file specified. (os error 2)
```
-rw-r--r--src/bootstrap/sanity.rs5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/bootstrap/sanity.rs b/src/bootstrap/sanity.rs
index ed0cbdf97b0..a28762ac485 100644
--- a/src/bootstrap/sanity.rs
+++ b/src/bootstrap/sanity.rs
@@ -93,7 +93,8 @@ pub fn check(build: &mut Build) {
                     .unwrap_or(true)
             })
             .any(|build_llvm_ourselves| build_llvm_ourselves);
-    if building_llvm || build.config.any_sanitizers_enabled() {
+    let need_cmake = building_llvm || build.config.any_sanitizers_enabled();
+    if need_cmake {
         cmd_finder.must_have("cmake");
     }
 
@@ -204,7 +205,7 @@ pub fn check(build: &mut Build) {
             }
         }
 
-        if target.contains("msvc") {
+        if need_cmake && target.contains("msvc") {
             // There are three builds of cmake on windows: MSVC, MinGW, and
             // Cygwin. The Cygwin build does not have generators for Visual
             // Studio, so detect that here and error.