diff options
| author | Christiaan Dirkx <christiaan@dirkx.email> | 2020-09-20 10:46:30 +0200 |
|---|---|---|
| committer | Christiaan Dirkx <christiaan@dirkx.email> | 2020-09-20 10:46:30 +0200 |
| commit | 292e2f71a76dd0b9ecb8a975e5e5564e7563d965 (patch) | |
| tree | 56c9a9355d358cb948181038c10e62859745a7f8 | |
| parent | 10d272b2e2678544f108d6ce573333cd11c27234 (diff) | |
| download | rust-292e2f71a76dd0b9ecb8a975e5e5564e7563d965.tar.gz rust-292e2f71a76dd0b9ecb8a975e5e5564e7563d965.zip | |
Remove `can_suggest` check for `is_ok` and `is_err`.
`is_ok` and `is_err` are stabilized as const and can thus always be suggested.
| -rw-r--r-- | clippy_lints/src/matches.rs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/clippy_lints/src/matches.rs b/clippy_lints/src/matches.rs index be879dfe28d..d20662f1ef9 100644 --- a/clippy_lints/src/matches.rs +++ b/clippy_lints/src/matches.rs @@ -1469,10 +1469,10 @@ mod redundant_pattern_match { keyword: &'static str, ) { fn find_suggestion(cx: &LateContext<'_>, hir_id: HirId, path: &QPath<'_>) -> Option<&'static str> { - if match_qpath(path, &paths::RESULT_OK) && can_suggest(cx, hir_id, sym!(result_type), "is_ok") { + if match_qpath(path, &paths::RESULT_OK) { return Some("is_ok()"); } - if match_qpath(path, &paths::RESULT_ERR) && can_suggest(cx, hir_id, sym!(result_type), "is_err") { + if match_qpath(path, &paths::RESULT_ERR) { return Some("is_err()"); } if match_qpath(path, &paths::OPTION_SOME) && can_suggest(cx, hir_id, sym!(option_type), "is_some") { @@ -1562,8 +1562,8 @@ mod redundant_pattern_match { &paths::RESULT_ERR, "is_ok()", "is_err()", - || can_suggest(cx, hir_id, sym!(result_type), "is_ok"), - || can_suggest(cx, hir_id, sym!(result_type), "is_err"), + || true, + || true ) } else { None |
