diff options
| author | Michael Wright <mikerite@lavabit.com> | 2022-06-05 07:22:45 +0200 |
|---|---|---|
| committer | Michael Wright <mikerite@lavabit.com> | 2022-06-05 07:30:59 +0200 |
| commit | 2a1a80d80cdc75ed0bb9f35744591089b8a89f31 (patch) | |
| tree | c950a0218ab37077420091a53d127cd1d7a65435 | |
| parent | 94e321a6ff9a224f690b355fd4298caf6342e883 (diff) | |
| download | rust-2a1a80d80cdc75ed0bb9f35744591089b8a89f31.tar.gz rust-2a1a80d80cdc75ed0bb9f35744591089b8a89f31.zip | |
needless_late_init refactoring
Simplify the creation of suggestions by using `flat_map` instead of `chain`. Note that the order of the suggestions is not important.
| -rw-r--r-- | clippy_lints/src/needless_late_init.rs | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/clippy_lints/src/needless_late_init.rs b/clippy_lints/src/needless_late_init.rs index 9c4e2ef6712..5e97c606e21 100644 --- a/clippy_lints/src/needless_late_init.rs +++ b/clippy_lints/src/needless_late_init.rs @@ -185,12 +185,12 @@ fn assignment_suggestions<'tcx>( let suggestions = assignments .iter() - .map(|assignment| assignment.span.until(assignment.rhs_span)) - .chain( - assignments - .iter() - .map(|assignment| assignment.rhs_span.shrink_to_hi().with_hi(assignment.span.hi())), - ) + .flat_map(|assignment| { + [ + assignment.span.until(assignment.rhs_span), + assignment.rhs_span.shrink_to_hi().with_hi(assignment.span.hi()), + ] + }) .map(|span| Some((span, String::new()))) .collect::<Option<Vec<(Span, String)>>>()?; |