diff options
| author | Aliénore Bouttefeux <alienore.bouttefeux@gmail.com> | 2021-04-16 19:38:01 +0200 |
|---|---|---|
| committer | Aliénore Bouttefeux <alienore.bouttefeux@gmail.com> | 2021-04-16 19:38:01 +0200 |
| commit | 2d050f4b2f6057ea0ac63a3d8d37c05992e4ee3e (patch) | |
| tree | 8630188f6b532c8c9682f11083d830ce3eebc82b | |
| parent | 1e0a3ff55c494dcb660e4cdae2dc4b697815dc86 (diff) | |
| download | rust-2d050f4b2f6057ea0ac63a3d8d37c05992e4ee3e.tar.gz rust-2d050f4b2f6057ea0ac63a3d8d37c05992e4ee3e.zip | |
add type in help of from over Into
| -rw-r--r-- | clippy_lints/src/from_over_into.rs | 2 | ||||
| -rw-r--r-- | tests/ui/from_over_into.stderr | 3 |
2 files changed, 2 insertions, 3 deletions
diff --git a/clippy_lints/src/from_over_into.rs b/clippy_lints/src/from_over_into.rs index e5ec245e502..5e2baba8943 100644 --- a/clippy_lints/src/from_over_into.rs +++ b/clippy_lints/src/from_over_into.rs @@ -73,7 +73,7 @@ impl LateLintPass<'_> for FromOverInto { cx.tcx.sess.source_map().guess_head_span(item.span), "an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true", None, - "consider to implement `From` instead", + &format!("consider to implement `From<{}>` instead", impl_trait_ref.self_ty()), ); } } diff --git a/tests/ui/from_over_into.stderr b/tests/ui/from_over_into.stderr index b101d2704fb..fb391759dce 100644 --- a/tests/ui/from_over_into.stderr +++ b/tests/ui/from_over_into.stderr @@ -5,7 +5,6 @@ LL | impl Into<StringWrapper> for String { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D clippy::from-over-into` implied by `-D warnings` - = help: consider to implement `From` instead + = help: consider to implement `From<std::string::String>` instead error: aborting due to previous error - |