about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2016-05-19 05:48:11 -0700
committerbors <bors@rust-lang.org>2016-05-19 05:48:11 -0700
commit2fb6f8e2c94a7041877ed8460f2621974c5233f7 (patch)
tree9e10f355a0e23c53c3204fbd178a97f2a4511d3c
parentd0ca0ca0631eb7105c51b1dc4153594d4b9dfbfd (diff)
parent59e5a5c322710f7b0af9b13b25ef3c23e33a2e7c (diff)
downloadrust-2fb6f8e2c94a7041877ed8460f2621974c5233f7.tar.gz
rust-2fb6f8e2c94a7041877ed8460f2621974c5233f7.zip
Auto merge of #33702 - crimsun:pr33678, r=alexcrichton
Resolved rustdoc crash (#33678) by aborting instead of unwrapping.

Also removed Option use and comment to match.

Fixes https://github.com/rust-lang/rust/issues/33678
-rw-r--r--src/librustdoc/core.rs7
1 files changed, 3 insertions, 4 deletions
diff --git a/src/librustdoc/core.rs b/src/librustdoc/core.rs
index 4ae869c3259..61985d39080 100644
--- a/src/librustdoc/core.rs
+++ b/src/librustdoc/core.rs
@@ -173,9 +173,8 @@ pub fn run_core(search_paths: SearchPaths,
                                                      &arenas,
                                                      &name,
                                                      |tcx, _, analysis, result| {
-        // Return if the driver hit an err (in `result`)
         if let Err(_) = result {
-            return None
+            sess.fatal("Compilation failed, aborting rustdoc");
         }
 
         let ty::CrateAnalysis { access_levels, .. } = analysis;
@@ -206,6 +205,6 @@ pub fn run_core(search_paths: SearchPaths,
             v.clean(&ctxt)
         };
 
-        Some((krate, ctxt.renderinfo.into_inner()))
-    }), &sess).unwrap()
+        (krate, ctxt.renderinfo.into_inner())
+    }), &sess)
 }