about summary refs log tree commit diff
diff options
context:
space:
mode:
authorPietro Albini <pietro@pietroalbini.org>2018-10-04 12:20:11 +0200
committerGitHub <noreply@github.com>2018-10-04 12:20:11 +0200
commit2fda2f6f13e6e3bbbcd4e578b1d68a5a02a2b9e0 (patch)
tree507b767d603827c69fbb22428deb918db42cac08
parentfdc16605eca3c5405e67e0a36b818522f58ee109 (diff)
parentd686896f907c75083c61783fe17b3f90e8985428 (diff)
downloadrust-2fda2f6f13e6e3bbbcd4e578b1d68a5a02a2b9e0.tar.gz
rust-2fda2f6f13e6e3bbbcd4e578b1d68a5a02a2b9e0.zip
Rollup merge of #54773 - rust-lang:wesleywiser-patch-1, r=oli-obk
Update a FIXME in memory.rs

In  #51833, I improved the performance of `copy_undef_mask()`. As such, the old FIXME wasn't appropriate anymore. The main remaining thing left to do is to implement a fast path for non-overlapping copies (per @oli-obk).

r? @oli-obk
-rw-r--r--src/librustc_mir/interpret/memory.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/librustc_mir/interpret/memory.rs b/src/librustc_mir/interpret/memory.rs
index 11e27a597fb..222d1164667 100644
--- a/src/librustc_mir/interpret/memory.rs
+++ b/src/librustc_mir/interpret/memory.rs
@@ -971,7 +971,7 @@ impl<'a, 'mir, 'tcx, M: Machine<'a, 'mir, 'tcx>> Memory<'a, 'mir, 'tcx, M> {
 
 /// Undefined bytes
 impl<'a, 'mir, 'tcx, M: Machine<'a, 'mir, 'tcx>> Memory<'a, 'mir, 'tcx, M> {
-    // FIXME(solson): This is a very naive, slow version.
+    // FIXME: Add a fast version for the common, nonoverlapping case
     fn copy_undef_mask(
         &mut self,
         src: Pointer,