about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJonas Schievink <jonasschievink@gmail.com>2021-04-09 22:52:13 +0200
committerJonas Schievink <jonasschievink@gmail.com>2021-04-09 22:52:13 +0200
commit30ce8b20ec70e8eb5d2203c4dbf104f57dfca49b (patch)
tree02fd9fd5dc8dd425e717d8237d622ef0336f3c05
parent343b14f7e06f3ec82a15b3648ba229e03e0b0583 (diff)
downloadrust-30ce8b20ec70e8eb5d2203c4dbf104f57dfca49b.tar.gz
rust-30ce8b20ec70e8eb5d2203c4dbf104f57dfca49b.zip
Avoid an unnecessary `collect`
-rw-r--r--crates/hir_def/src/attr.rs4
1 files changed, 1 insertions, 3 deletions
diff --git a/crates/hir_def/src/attr.rs b/crates/hir_def/src/attr.rs
index dd99c8d15a8..786fad6e1d5 100644
--- a/crates/hir_def/src/attr.rs
+++ b/crates/hir_def/src/attr.rs
@@ -751,9 +751,7 @@ fn collect_attrs(
         .chain(inner_docs.into_iter().flatten())
         .map(|docs_text| (docs_text.syntax().text_range().start(), Either::Right(docs_text)));
     // sort here by syntax node offset because the source can have doc attributes and doc strings be interleaved
-    let attrs: Vec<_> = docs.chain(attrs).sorted_by_key(|&(offset, _)| offset).collect();
-
-    attrs.into_iter().map(|(_, attr)| attr)
+    docs.chain(attrs).sorted_by_key(|&(offset, _)| offset).map(|(_, attr)| attr)
 }
 
 pub(crate) fn variants_attrs_source_map(