diff options
| author | Philipp Hansch <dev@phansch.net> | 2019-06-10 10:59:03 +0200 |
|---|---|---|
| committer | Philipp Hansch <dev@phansch.net> | 2019-06-10 11:47:42 +0200 |
| commit | 33137ffdd5ffd7b80b01dafa88f2f4f301ef6b25 (patch) | |
| tree | 444cfc46106a1c8c7d6b90f8b9998ffdbce1fc7d | |
| parent | e3516a128e55ffd175527add83ac9ca721a94ed7 (diff) | |
| download | rust-33137ffdd5ffd7b80b01dafa88f2f4f301ef6b25.tar.gz rust-33137ffdd5ffd7b80b01dafa88f2f4f301ef6b25.zip | |
Address review comments
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
| -rw-r--r-- | src/librustc/session/config.rs | 4 | ||||
| -rw-r--r-- | src/librustc_errors/diagnostic_builder.rs | 2 | ||||
| -rw-r--r-- | src/librustc_errors/lib.rs | 3 |
3 files changed, 5 insertions, 4 deletions
diff --git a/src/librustc/session/config.rs b/src/librustc/session/config.rs index d70ea1ee8e6..86a606b5fd3 100644 --- a/src/librustc/session/config.rs +++ b/src/librustc/session/config.rs @@ -227,14 +227,14 @@ impl OutputType { } } -/// The type of diagnostics output to generate +/// The type of diagnostics output to generate. #[derive(Clone, Copy, Debug, PartialEq, Eq)] pub enum ErrorOutputType { /// Output meant for the consumption of humans. HumanReadable(HumanReadableErrorType), /// Output that's consumed by other tools such as `rustfix` or the `RLS`. Json { - /// Render the JSON in a human readable way (with indents and newlines) + /// Render the JSON in a human readable way (with indents and newlines). pretty: bool, /// The JSON output includes a `rendered` field that includes the rendered /// human output. diff --git a/src/librustc_errors/diagnostic_builder.rs b/src/librustc_errors/diagnostic_builder.rs index b130a9d5a23..fc74e43ff57 100644 --- a/src/librustc_errors/diagnostic_builder.rs +++ b/src/librustc_errors/diagnostic_builder.rs @@ -348,7 +348,7 @@ impl<'a> DiagnosticBuilder<'a> { /// Convenience function for internal use, clients should use one of the /// struct_* methods on Handler. - pub(crate) fn new_with_code(handler: &'a Handler, + crate fn new_with_code(handler: &'a Handler, level: Level, code: Option<DiagnosticId>, message: &str) diff --git a/src/librustc_errors/lib.rs b/src/librustc_errors/lib.rs index 589e93f48b3..6ec1b90cd91 100644 --- a/src/librustc_errors/lib.rs +++ b/src/librustc_errors/lib.rs @@ -1,9 +1,10 @@ -//! Diagnostics creation and emission for rustc +//! Diagnostics creation and emission for `rustc`. //! //! This module contains the code for creating and emitting diagnostics. #![doc(html_root_url = "https://doc.rust-lang.org/nightly/")] +#![feature(crate_visibility_modifier)] #![allow(unused_attributes)] #![cfg_attr(unix, feature(libc))] #![feature(nll)] |