about summary refs log tree commit diff
diff options
context:
space:
mode:
authorStuart Cook <Zalathar@users.noreply.github.com>2025-09-16 10:25:41 +1000
committerGitHub <noreply@github.com>2025-09-16 10:25:41 +1000
commit336e45e041177e555b4096892fca1adc8c830e57 (patch)
treeaaf0a89002a70483daecfa914b60ff563af8bf9d
parent9eaf3c8864122850e284f9409dd9a920e6e3d0d1 (diff)
parent96f8dbe1b33691a949b23a005581b66c6f7e4cbf (diff)
downloadrust-336e45e041177e555b4096892fca1adc8c830e57.tar.gz
rust-336e45e041177e555b4096892fca1adc8c830e57.zip
Rollup merge of #146574 - Zalathar:capture, r=jieyouxu
compiletest: Enable new-output-capture by default

The new output-capture implementation was added in rust-lang/rust#146119, but was disabled by default and required opt-in.

Since then, I haven't encountered any problems in my own testing/usage, and I haven't heard any problem reports from other contributors who might have opted in.

It's unlikely that more opt-in testing will help, so the next step is to enable new-output-capture by default and see if anyone complains. (Hopefully nobody!)

If needed, the new default can be overridden (for now) by setting environment variable `COMPILETEST_NEW_OUTPUT_CAPTURE=off`. Please file an issue (or let me know) if anyone finds a reason to do this.

r? jieyouxu
-rw-r--r--src/tools/compiletest/src/lib.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tools/compiletest/src/lib.rs b/src/tools/compiletest/src/lib.rs
index 5e349a20ed2..ce2a3d4b5fb 100644
--- a/src/tools/compiletest/src/lib.rs
+++ b/src/tools/compiletest/src/lib.rs
@@ -484,7 +484,7 @@ pub fn parse_config(args: Vec<String>) -> Config {
             let value = matches
                 .opt_str("new-output-capture")
                 .or_else(|| env::var("COMPILETEST_NEW_OUTPUT_CAPTURE").ok())
-                .unwrap_or_else(|| "off".to_owned());
+                .unwrap_or_else(|| "on".to_owned());
             parse_bool_option(&value)
                 .unwrap_or_else(|| panic!("unknown `--new-output-capture` value `{value}` given"))
         },