diff options
| author | Lukas Wirth <lukastw97@gmail.com> | 2023-03-09 15:30:17 +0100 |
|---|---|---|
| committer | Lukas Wirth <lukastw97@gmail.com> | 2023-03-09 15:30:17 +0100 |
| commit | 3427d36d0e47a5266feb2e501876c60584600974 (patch) | |
| tree | acec3b6efd8040b2257a45587d2e913c24dbdb42 | |
| parent | e158dc72465d79084184b34054239544f5bab095 (diff) | |
| download | rust-3427d36d0e47a5266feb2e501876c60584600974.tar.gz rust-3427d36d0e47a5266feb2e501876c60584600974.zip | |
fix: Fix search not searching bodies of attributed items
| -rw-r--r-- | crates/hir-expand/src/lib.rs | 17 | ||||
| -rw-r--r-- | crates/ide-db/src/search.rs | 6 |
2 files changed, 19 insertions, 4 deletions
diff --git a/crates/hir-expand/src/lib.rs b/crates/hir-expand/src/lib.rs index e4719237a2a..39fc08ecdcf 100644 --- a/crates/hir-expand/src/lib.rs +++ b/crates/hir-expand/src/lib.rs @@ -815,7 +815,7 @@ impl<'a> InFile<&'a SyntaxNode> { /// Falls back to the macro call range if the node cannot be mapped up fully. /// /// For attributes and derives, this will point back to the attribute only. - /// For the entire item `InFile::use original_file_range_full`. + /// For the entire item use [`InFile::original_file_range_full`]. pub fn original_file_range(self, db: &dyn db::AstDatabase) -> FileRange { match self.file_id.repr() { HirFileIdRepr::FileId(file_id) => FileRange { file_id, range: self.value.text_range() }, @@ -830,6 +830,21 @@ impl<'a> InFile<&'a SyntaxNode> { } } + /// Falls back to the macro call range if the node cannot be mapped up fully. + pub fn original_file_range_full(self, db: &dyn db::AstDatabase) -> FileRange { + match self.file_id.repr() { + HirFileIdRepr::FileId(file_id) => FileRange { file_id, range: self.value.text_range() }, + HirFileIdRepr::MacroFile(mac_file) => { + if let Some(res) = self.original_file_range_opt(db) { + return res; + } + // Fall back to whole macro call. + let loc = db.lookup_intern_macro_call(mac_file.macro_call_id); + loc.kind.original_call_range_with_body(db) + } + } + } + /// Attempts to map the syntax node back up its macro calls. pub fn original_file_range_opt(self, db: &dyn db::AstDatabase) -> Option<FileRange> { match ascend_node_border_tokens(db, self) { diff --git a/crates/ide-db/src/search.rs b/crates/ide-db/src/search.rs index 77d694b57f8..12f5e4e2a23 100644 --- a/crates/ide-db/src/search.rs +++ b/crates/ide-db/src/search.rs @@ -244,14 +244,14 @@ impl Definition { DefWithBody::Variant(v) => v.source(db).map(|src| src.syntax().cloned()), }; return match def { - Some(def) => SearchScope::file_range(def.as_ref().original_file_range(db)), + Some(def) => SearchScope::file_range(def.as_ref().original_file_range_full(db)), None => SearchScope::single_file(file_id), }; } if let Definition::SelfType(impl_) = self { return match impl_.source(db).map(|src| src.syntax().cloned()) { - Some(def) => SearchScope::file_range(def.as_ref().original_file_range(db)), + Some(def) => SearchScope::file_range(def.as_ref().original_file_range_full(db)), None => SearchScope::single_file(file_id), }; } @@ -268,7 +268,7 @@ impl Definition { hir::GenericDef::Const(it) => it.source(db).map(|src| src.syntax().cloned()), }; return match def { - Some(def) => SearchScope::file_range(def.as_ref().original_file_range(db)), + Some(def) => SearchScope::file_range(def.as_ref().original_file_range_full(db)), None => SearchScope::single_file(file_id), }; } |
