diff options
| author | Ralf Jung <post@ralfj.de> | 2024-10-25 14:50:10 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-10-25 14:50:10 +0000 |
| commit | 3432b91bbc863f8cacbb417afcfc1c0960740d9e (patch) | |
| tree | db5c8f3da679651d2fd9a1cd096639319fe74e91 | |
| parent | cbf6c86f56614943b66be999c21d11c31dc07628 (diff) | |
| parent | e5d32b67578083f59db8e8ea397db9ac7b9597ff (diff) | |
| download | rust-3432b91bbc863f8cacbb417afcfc1c0960740d9e.tar.gz rust-3432b91bbc863f8cacbb417afcfc1c0960740d9e.zip | |
Merge pull request #3989 from RalfJung/ci
CI workflow: tweak conclusion job
| -rw-r--r-- | src/tools/miri/.github/workflows/ci.yml | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/tools/miri/.github/workflows/ci.yml b/src/tools/miri/.github/workflows/ci.yml index 400a012deed..f3975ec7389 100644 --- a/src/tools/miri/.github/workflows/ci.yml +++ b/src/tools/miri/.github/workflows/ci.yml @@ -34,7 +34,7 @@ jobs: # The `style` job only runs on Linux; this makes sure the Windows-host-specific # code is also covered by clippy. - name: Check clippy - if: matrix.os == 'windows-latest' + if: ${{ matrix.os == 'windows-latest' }} run: ./miri clippy -- -D warnings - name: Test Miri @@ -58,14 +58,15 @@ jobs: - name: rustdoc run: RUSTDOCFLAGS="-Dwarnings" ./miri doc --document-private-items + # Summary job for the merge queue. + # ALL THE PREVIOUS JOBS NEED TO BE ADDED TO THE `needs` SECTION OF THIS JOB! + # And they should be added below in `cron-fail-notify` as well. conclusion: needs: [build, style] # We need to ensure this job does *not* get skipped if its dependencies fail, # because a skipped job is considered a success by GitHub. So we have to # overwrite `if:`. We use `!cancelled()` to ensure the job does still not get run # when the workflow is canceled manually. - # - # ALL THE PREVIOUS JOBS NEED TO BE ADDED TO THE `needs` SECTION OF THIS JOB! if: ${{ !cancelled() }} runs-on: ubuntu-latest steps: @@ -86,7 +87,7 @@ jobs: # ... and create a PR. pull-requests: write needs: [build, style] - if: github.event_name == 'schedule' && failure() + if: ${{ github.event_name == 'schedule' && failure() }} steps: # Send a Zulip notification - name: Install zulip-send |