diff options
| author | Yuki Okushi <jtitor@2k36.org> | 2021-10-21 14:11:09 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-10-21 14:11:09 +0900 |
| commit | 371fd4f1c05bd0cf2cd6c4912e0cc83460075370 (patch) | |
| tree | 88af53f85ba51fc955d67642dfa9cc99064f24e9 | |
| parent | afdd0c3adedd5839e6d89a6d5ae8d0acfee0aae7 (diff) | |
| parent | f3fb821f3b5a762f8e053b56f1982aee18c82060 (diff) | |
| download | rust-371fd4f1c05bd0cf2cd6c4912e0cc83460075370.tar.gz rust-371fd4f1c05bd0cf2cd6c4912e0cc83460075370.zip | |
Rollup merge of #90074 - klensy:upvar-all, r=wesleywiser
2229 migrations small cleanup This removes needless `format!`'ing of empty string and replaces `vec!` with const strings with const array.
| -rw-r--r-- | compiler/rustc_typeck/src/check/upvar.rs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/compiler/rustc_typeck/src/check/upvar.rs b/compiler/rustc_typeck/src/check/upvar.rs index caad28ff2b2..9c7b0b2cacb 100644 --- a/compiler/rustc_typeck/src/check/upvar.rs +++ b/compiler/rustc_typeck/src/check/upvar.rs @@ -883,8 +883,8 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { self.tcx.get_diagnostic_item(sym::unwind_safe_trait), self.tcx.get_diagnostic_item(sym::ref_unwind_safe_trait), ]; - let auto_traits = - vec!["`Clone`", "`Sync`", "`Send`", "`Unpin`", "`UnwindSafe`", "`RefUnwindSafe`"]; + const AUTO_TRAITS: [&str; 6] = + ["`Clone`", "`Sync`", "`Send`", "`Unpin`", "`UnwindSafe`", "`RefUnwindSafe`"]; let root_var_min_capture_list = min_captures.and_then(|m| m.get(&var_hir_id))?; @@ -957,7 +957,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { // by the root variable but not by the capture for (idx, _) in obligations_should_hold.iter().enumerate() { if !obligations_holds_for_capture[idx] && obligations_should_hold[idx] { - capture_problems.insert(auto_traits[idx]); + capture_problems.insert(AUTO_TRAITS[idx]); } } @@ -1074,7 +1074,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { min_captures: Option<&ty::RootVariableMinCaptureList<'tcx>>, ) -> (Vec<MigrationDiagnosticInfo>, String) { let Some(upvars) = self.tcx.upvars_mentioned(closure_def_id) else { - return (Vec::new(), format!("")); + return (Vec::new(), String::new()); }; let mut need_migrations = Vec::new(); |
