diff options
| author | bors <bors@rust-lang.org> | 2019-05-23 05:43:15 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2019-05-23 05:43:15 +0000 |
| commit | 39d1fea6d60235ee1fae82acf326c88e488bc110 (patch) | |
| tree | bd2e2e89326b93ae8966cc81ebcf76b0312d3676 | |
| parent | 64c1d3bea7b6c8f8db4b4be7a01ad26c2c8c9cca (diff) | |
| parent | edb698105fdd123e5b4ac8880c861b508a80d55a (diff) | |
| download | rust-39d1fea6d60235ee1fae82acf326c88e488bc110.tar.gz rust-39d1fea6d60235ee1fae82acf326c88e488bc110.zip | |
Auto merge of #4126 - phansch:rustup, r=Manishearth
Rustup to https://github.com/rust-lang/rust/pull/60740 https://github.com/rust-lang/rust/pull/60740 changelog: none
| -rw-r--r-- | clippy_lints/src/const_static_lifetime.rs | 2 | ||||
| -rw-r--r-- | clippy_lints/src/lifetimes.rs | 6 | ||||
| -rw-r--r-- | clippy_lints/src/use_self.rs | 4 | ||||
| -rw-r--r-- | clippy_lints/src/utils/mod.rs | 4 |
4 files changed, 7 insertions, 9 deletions
diff --git a/clippy_lints/src/const_static_lifetime.rs b/clippy_lints/src/const_static_lifetime.rs index 150d379cc7c..fefd180953f 100644 --- a/clippy_lints/src/const_static_lifetime.rs +++ b/clippy_lints/src/const_static_lifetime.rs @@ -47,7 +47,7 @@ impl StaticConst { if let Some(lifetime) = *optional_lifetime { match borrow_type.ty.node { TyKind::Path(..) | TyKind::Slice(..) | TyKind::Array(..) | TyKind::Tup(..) => { - if lifetime.ident.name == syntax::symbol::keywords::StaticLifetime.name() { + if lifetime.ident.name == syntax::symbol::kw::StaticLifetime { let snip = snippet(cx, borrow_type.ty.span, "<type>"); let sugg = format!("&{}", snip); span_lint_and_then( diff --git a/clippy_lints/src/lifetimes.rs b/clippy_lints/src/lifetimes.rs index ff75fbaa55f..8c167db9131 100644 --- a/clippy_lints/src/lifetimes.rs +++ b/clippy_lints/src/lifetimes.rs @@ -6,7 +6,7 @@ use rustc::lint::{in_external_macro, LateContext, LateLintPass, LintArray, LintC use rustc::{declare_lint_pass, declare_tool_lint}; use rustc_data_structures::fx::{FxHashMap, FxHashSet}; use syntax::source_map::Span; -use syntax::symbol::keywords; +use syntax::symbol::kw; use crate::reexport::*; use crate::utils::{last_path_segment, span_lint}; @@ -476,9 +476,7 @@ struct BodyLifetimeChecker { impl<'tcx> Visitor<'tcx> for BodyLifetimeChecker { // for lifetimes as parameters of generics fn visit_lifetime(&mut self, lifetime: &'tcx Lifetime) { - if lifetime.name.ident().name != keywords::Invalid.name() - && lifetime.name.ident().name != syntax::symbol::keywords::StaticLifetime.name() - { + if lifetime.name.ident().name != kw::Invalid && lifetime.name.ident().name != kw::StaticLifetime { self.lifetimes_used_in_body = true; } } diff --git a/clippy_lints/src/use_self.rs b/clippy_lints/src/use_self.rs index 1a0a3474d88..c6ada386f2a 100644 --- a/clippy_lints/src/use_self.rs +++ b/clippy_lints/src/use_self.rs @@ -8,7 +8,7 @@ use rustc::ty; use rustc::ty::{DefIdTree, Ty}; use rustc::{declare_lint_pass, declare_tool_lint}; use rustc_errors::Applicability; -use syntax_pos::symbol::keywords::SelfUpper; +use syntax_pos::symbol::kw; use crate::utils::span_lint_and_sugg; @@ -220,7 +220,7 @@ struct UseSelfVisitor<'a, 'tcx: 'a> { impl<'a, 'tcx> Visitor<'tcx> for UseSelfVisitor<'a, 'tcx> { fn visit_path(&mut self, path: &'tcx Path, _id: HirId) { - if path.segments.last().expect(SEGMENTS_MSG).ident.name != SelfUpper.name() { + if path.segments.last().expect(SEGMENTS_MSG).ident.name != kw::SelfUpper { if self.item_path.res == path.res { span_use_self_lint(self.cx, path); } else if let Res::Def(DefKind::Ctor(def::CtorOf::Struct, CtorKind::Fn), ctor_did) = path.res { diff --git a/clippy_lints/src/utils/mod.rs b/clippy_lints/src/utils/mod.rs index 3d22732a6d4..b28615ec54c 100644 --- a/clippy_lints/src/utils/mod.rs +++ b/clippy_lints/src/utils/mod.rs @@ -45,7 +45,7 @@ use syntax::ast::{self, LitKind}; use syntax::attr; use syntax::ext::hygiene::ExpnFormat; use syntax::source_map::{Span, DUMMY_SP}; -use syntax::symbol::{keywords, Symbol}; +use syntax::symbol::{kw, Symbol}; use crate::reexport::*; @@ -839,7 +839,7 @@ pub fn remove_blocks(expr: &Expr) -> &Expr { pub fn is_self(slf: &Arg) -> bool { if let PatKind::Binding(.., name, _) = slf.pat.node { - name.name == keywords::SelfLower.name() + name.name == kw::SelfLower } else { false } |
