about summary refs log tree commit diff
diff options
context:
space:
mode:
authorKirill Bulatov <mail4score@gmail.com>2025-03-15 21:27:18 +0200
committerKirill Bulatov <mail4score@gmail.com>2025-03-15 21:27:18 +0200
commit3bec5066bc1575a4ca0964439bb3874a037e65bc (patch)
tree8a3fe21710e34b9f1571aaa27a6fe96251237749
parent6e926fd2160a925e11f5adea1fbbc4acc00c1e92 (diff)
downloadrust-3bec5066bc1575a4ca0964439bb3874a037e65bc.tar.gz
rust-3bec5066bc1575a4ca0964439bb3874a037e65bc.zip
Do not error for actions with no data to resolve
Same as the other resolve code handlers in the same file.
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#version_3_17_0
does not forbid resolving with no data, so instead of erroring, just consider such items resolved already.
-rw-r--r--src/tools/rust-analyzer/crates/rust-analyzer/src/handlers/request.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tools/rust-analyzer/crates/rust-analyzer/src/handlers/request.rs b/src/tools/rust-analyzer/crates/rust-analyzer/src/handlers/request.rs
index 170481ea701..5f27567c31e 100644
--- a/src/tools/rust-analyzer/crates/rust-analyzer/src/handlers/request.rs
+++ b/src/tools/rust-analyzer/crates/rust-analyzer/src/handlers/request.rs
@@ -1480,7 +1480,7 @@ pub(crate) fn handle_code_action_resolve(
 ) -> anyhow::Result<lsp_ext::CodeAction> {
     let _p = tracing::info_span!("handle_code_action_resolve").entered();
     let Some(params) = code_action.data.take() else {
-        return Err(invalid_params_error("code action without data".to_owned()).into());
+        return Ok(code_action);
     };
 
     let file_id = from_proto::file_id(&snap, &params.code_action_params.text_document.uri)?