about summary refs log tree commit diff
diff options
context:
space:
mode:
authorMichael Goulet <michael@errs.io>2022-10-19 04:55:31 +0000
committerMichael Goulet <michael@errs.io>2022-10-22 06:59:49 +0000
commit3d7b1f0d18a4bdb667c6244b1748136c312cc9cf (patch)
tree8c2eab6069abe6487d444644a8777c32b488bfad
parenteecde5850cade0c058dc12330081329b31a826c7 (diff)
downloadrust-3d7b1f0d18a4bdb667c6244b1748136c312cc9cf.tar.gz
rust-3d7b1f0d18a4bdb667c6244b1748136c312cc9cf.zip
Don't erroneously deny semicolons after closure expr within parentheses in a macro
-rw-r--r--compiler/rustc_parse/src/parser/expr.rs4
-rw-r--r--src/test/ui/parser/semi-after-closure-in-macro.rs14
2 files changed, 18 insertions, 0 deletions
diff --git a/compiler/rustc_parse/src/parser/expr.rs b/compiler/rustc_parse/src/parser/expr.rs
index afa116ce1bc..5b466cec8e1 100644
--- a/compiler/rustc_parse/src/parser/expr.rs
+++ b/compiler/rustc_parse/src/parser/expr.rs
@@ -2051,6 +2051,10 @@ impl<'a> Parser<'a> {
 
         if self.token.kind == TokenKind::Semi
             && matches!(self.token_cursor.frame.delim_sp, Some((Delimiter::Parenthesis, _)))
+            // HACK: This is needed so we can detect whether we're inside a macro,
+            // where regular assumptions about what tokens can follow other tokens
+            // don't necessarily apply.
+            && self.subparser_name.is_none()
         {
             // It is likely that the closure body is a block but where the
             // braces have been removed. We will recover and eat the next
diff --git a/src/test/ui/parser/semi-after-closure-in-macro.rs b/src/test/ui/parser/semi-after-closure-in-macro.rs
new file mode 100644
index 00000000000..14efb6100b0
--- /dev/null
+++ b/src/test/ui/parser/semi-after-closure-in-macro.rs
@@ -0,0 +1,14 @@
+// check-pass
+
+// Checks that the fix in #103222 doesn't also disqualify semicolons after
+// closures within parentheses *in macros*, where they're totally allowed.
+
+macro_rules! m {
+    (($expr:expr ; )) => {
+        $expr
+    };
+}
+
+fn main() {
+    let x = m!(( ||() ; ));
+}