about summary refs log tree commit diff
diff options
context:
space:
mode:
authorSosthène Guédon <sosthene@guedon.gdn>2022-11-01 21:49:20 +0100
committerSosthène Guédon <sosthene@guedon.gdn>2022-11-20 13:45:12 +0100
commit3e2e81b2db9bbacc826ac429b52ac1173356a2e3 (patch)
tree5f670ed971736bb926a7a2816c376af1b37f0a34
parent5fa0e07cdf5e6798a71ff252f14a2713699ae99d (diff)
downloadrust-3e2e81b2db9bbacc826ac429b52ac1173356a2e3.tar.gz
rust-3e2e81b2db9bbacc826ac429b52ac1173356a2e3.zip
Fix internal warnings
-rw-r--r--clippy_lints/src/functions/missnamed_getters.rs5
-rw-r--r--clippy_lints/src/functions/mod.rs9
2 files changed, 9 insertions, 5 deletions
diff --git a/clippy_lints/src/functions/missnamed_getters.rs b/clippy_lints/src/functions/missnamed_getters.rs
index 306dccdbd48..3d78679b526 100644
--- a/clippy_lints/src/functions/missnamed_getters.rs
+++ b/clippy_lints/src/functions/missnamed_getters.rs
@@ -28,15 +28,14 @@ pub fn check_fn(
     let name = ident.name.as_str();
 
     let name = match sig.decl.implicit_self {
-        ImplicitSelfKind::ImmRef => name,
         ImplicitSelfKind::MutRef => {
             let Some(name) = name.strip_suffix("_mut") else {
                     return;
                 };
             name
         },
-        ImplicitSelfKind::Imm | ImplicitSelfKind::Mut => name,
-        _ => return,
+        ImplicitSelfKind::Imm | ImplicitSelfKind::Mut | ImplicitSelfKind::ImmRef => name,
+        ImplicitSelfKind::None => return,
     };
 
     // Body must be &(mut) <self_data>.name
diff --git a/clippy_lints/src/functions/mod.rs b/clippy_lints/src/functions/mod.rs
index 87792899b25..e4181a164cb 100644
--- a/clippy_lints/src/functions/mod.rs
+++ b/clippy_lints/src/functions/mod.rs
@@ -278,16 +278,21 @@ declare_clippy_lint! {
     ///
     /// impl A {
     ///     fn a(&self) -> &str{
-    ///         self.b
+    ///         &self.b
     ///     }
     /// }
     /// // example code where clippy issues a warning
     /// ```
     /// Use instead:
     /// ```rust
+    /// struct A {
+    ///     a: String,
+    ///     b: String,
+    /// }
+    ///
     /// impl A {
     ///     fn a(&self) -> &str{
-    ///         self.a
+    ///         &self.a
     ///     }
     /// }
     /// ```