diff options
| author | Ralf Jung <post@ralfj.de> | 2018-05-28 18:27:26 +0200 |
|---|---|---|
| committer | Ralf Jung <post@ralfj.de> | 2018-05-28 18:34:15 +0200 |
| commit | 3ee9d899695edf3a00870f6243c27c21d9084a8f (patch) | |
| tree | ccda38a4ee1f6e6726112b3c26e284e5629814cc | |
| parent | 2b1d69d6b520046108dae04c625f15ea35127388 (diff) | |
extend from_raw_parts docs for slices and strs to mention alignment requirement
| -rw-r--r-- | src/libcore/slice/mod.rs | 11 | ||||
| -rw-r--r-- | src/libcore/str/mod.rs | 10 |
2 files changed, 10 insertions, 11 deletions
diff --git a/src/libcore/slice/mod.rs b/src/libcore/slice/mod.rs index ab986e4c86d..d52cc8cbe3f 100644 --- a/src/libcore/slice/mod.rs +++ b/src/libcore/slice/mod.rs @@ -3839,10 +3839,9 @@ unsafe impl<'a, T> TrustedRandomAccess for ExactChunksMut<'a, T> { /// valid for `len` elements, nor whether the lifetime inferred is a suitable /// lifetime for the returned slice. /// -/// `p` must be non-null, even for zero-length slices, because non-zero bits -/// are required to distinguish between a zero-length slice within `Some()` -/// from `None`. `p` can be a bogus non-dereferencable pointer, such as `0x1`, -/// for zero-length slices, though. +/// `p` must be non-null and aligned, even for zero-length slices, as is +/// required for all references. However, for zero-length slices, `p` can be +/// a bogus non-dereferencable pointer such as [`NonNull::dangling()`]. /// /// # Caveat /// @@ -3864,6 +3863,8 @@ unsafe impl<'a, T> TrustedRandomAccess for ExactChunksMut<'a, T> { /// let slice = slice::from_raw_parts(ptr, amt); /// } /// ``` +/// +/// [`NonNull::dangling()`]: ../../std/ptr/struct.NonNull.html#method.dangling #[inline] #[stable(feature = "rust1", since = "1.0.0")] pub unsafe fn from_raw_parts<'a, T>(data: *const T, len: usize) -> &'a [T] { @@ -3875,7 +3876,7 @@ pub unsafe fn from_raw_parts<'a, T>(data: *const T, len: usize) -> &'a [T] { /// /// This function is unsafe for the same reasons as `from_raw_parts`, as well /// as not being able to provide a non-aliasing guarantee of the returned -/// mutable slice. `p` must be non-null even for zero-length slices as with +/// mutable slice. `p` must be non-null and aligned even for zero-length slices as with /// `from_raw_parts`. #[inline] #[stable(feature = "rust1", since = "1.0.0")] diff --git a/src/libcore/str/mod.rs b/src/libcore/str/mod.rs index 13d808ede5f..ea0a0b74db6 100644 --- a/src/libcore/str/mod.rs +++ b/src/libcore/str/mod.rs @@ -388,10 +388,9 @@ pub fn from_utf8_mut(v: &mut [u8]) -> Result<&mut str, Utf8Error> { /// /// The data must be valid UTF-8 /// -/// `p` must be non-null, even for zero-length strs, because non-zero bits -/// are required to distinguish between a zero-length str within `Some()` -/// from `None`. `p` can be a bogus non-dereferencable pointer, such as `0x1`, -/// for zero-length strs, though. +/// `p` must be non-null and aligned, even for zero-length strs, as is +/// required for all references. However, for zero-length strs, `p` can be +/// a bogus non-dereferencable pointer such as [`NonNull::dangling()`]. /// /// # Caveat /// @@ -400,9 +399,8 @@ pub fn from_utf8_mut(v: &mut [u8]) -> Result<&mut str, Utf8Error> { /// source lifetime is safe in the context, such as by providing a helper /// function taking the lifetime of a host value for the str, or by explicit /// annotation. -/// Performs the same functionality as `from_raw_parts`, except that a mutable -/// str is returned. /// +/// [`NonNull::dangling()`]: ../../std/ptr/struct.NonNull.html#method.dangling unsafe fn from_raw_parts_mut<'a>(p: *mut u8, len: usize) -> &'a mut str { from_utf8_unchecked_mut(slice::from_raw_parts_mut(p, len)) } |
