diff options
| author | Jakub Beránek <berykubik@gmail.com> | 2025-07-02 12:18:56 +0200 |
|---|---|---|
| committer | Jakub Beránek <berykubik@gmail.com> | 2025-07-02 12:18:56 +0200 |
| commit | 3f3c49813706e692ccabd7d8fac990f7b9525699 (patch) | |
| tree | 6b891c7a3eb1b6e1e7ee317cb61ef4ad2f654323 | |
| parent | e6c64df274407ab63f817c5e7712afc289d89a3c (diff) | |
| download | rust-3f3c49813706e692ccabd7d8fac990f7b9525699.tar.gz rust-3f3c49813706e692ccabd7d8fac990f7b9525699.zip | |
Apply review comments
| -rw-r--r-- | src/bootstrap/src/core/builder/mod.rs | 2 | ||||
| -rw-r--r-- | src/bootstrap/src/core/builder/tests.rs | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/src/bootstrap/src/core/builder/mod.rs b/src/bootstrap/src/core/builder/mod.rs index 930efaf0f45..b96a988cde3 100644 --- a/src/bootstrap/src/core/builder/mod.rs +++ b/src/bootstrap/src/core/builder/mod.rs @@ -186,6 +186,8 @@ impl StepMetadata { pub fn get_stage(&self) -> Option<u32> { self.stage.or(self .built_by + // For std, its stage corresponds to the stage of the compiler that builds it. + // For everything else, a stage N things gets built by a stage N-1 compiler. .map(|compiler| if self.name == "std" { compiler.stage } else { compiler.stage + 1 })) } } diff --git a/src/bootstrap/src/core/builder/tests.rs b/src/bootstrap/src/core/builder/tests.rs index a6a147682db..1c5267cb75e 100644 --- a/src/bootstrap/src/core/builder/tests.rs +++ b/src/bootstrap/src/core/builder/tests.rs @@ -1667,8 +1667,7 @@ fn render_metadata(metadata: &StepMetadata) -> String { if let Some(compiler) = metadata.built_by { write!(record, "{} -> ", render_compiler(compiler)); } - let stage = - if let Some(stage) = metadata.get_stage() { format!("{stage} ") } else { "".to_string() }; + let stage = metadata.get_stage().map(|stage| format!("{stage} ")).unwrap_or_default(); write!(record, "{} {stage}<{}>", metadata.name, normalize_target(metadata.target)); record } |
