diff options
| author | PotHix <pothix@pothix.com> | 2019-11-07 22:46:45 -0300 |
|---|---|---|
| committer | PotHix <pothix@pothix.com> | 2019-11-08 12:32:46 -0300 |
| commit | 3fa8692a5e5f69133464dabb52f549a46529ffe6 (patch) | |
| tree | 7d5f6c6b9d2245b35a9308184ed34c8dee7dcc77 | |
| parent | e8f43b72eb2596f360004f6cdf9cdde4b9e789e1 (diff) | |
| download | rust-3fa8692a5e5f69133464dabb52f549a46529ffe6.tar.gz rust-3fa8692a5e5f69133464dabb52f549a46529ffe6.zip | |
Suggest `#[repr(C)]` instead of `#[repr(C, packed, ...)]`
The code was previously suggesting `#[repr(C, packed, ...)]` for incorrect uses of `repr` (e.g. `#[repr = "C"]`). This change suggests the usage of `#[repr(C)]` instead. r? @estebank ref #61286
| -rw-r--r-- | src/libsyntax/feature_gate/builtin_attrs.rs | 2 | ||||
| -rw-r--r-- | src/test/ui/issues/issue-43988.stderr | 4 | ||||
| -rw-r--r-- | src/test/ui/repr.stderr | 6 |
3 files changed, 6 insertions, 6 deletions
diff --git a/src/libsyntax/feature_gate/builtin_attrs.rs b/src/libsyntax/feature_gate/builtin_attrs.rs index b32a887c6b2..157c755a1b1 100644 --- a/src/libsyntax/feature_gate/builtin_attrs.rs +++ b/src/libsyntax/feature_gate/builtin_attrs.rs @@ -231,7 +231,7 @@ pub const BUILTIN_ATTRIBUTES: &[BuiltinAttribute] = &[ ), ungated!(link_name, Whitelisted, template!(NameValueStr: "name")), ungated!(no_link, Normal, template!(Word)), - ungated!(repr, Normal, template!(List: "C, packed, ...")), + ungated!(repr, Normal, template!(List: "C")), ungated!(export_name, Whitelisted, template!(NameValueStr: "name")), ungated!(link_section, Whitelisted, template!(NameValueStr: "name")), ungated!(no_mangle, Whitelisted, template!(Word)), diff --git a/src/test/ui/issues/issue-43988.stderr b/src/test/ui/issues/issue-43988.stderr index 339c1a3b8f6..37e56168c1d 100644 --- a/src/test/ui/issues/issue-43988.stderr +++ b/src/test/ui/issues/issue-43988.stderr @@ -2,13 +2,13 @@ error: malformed `repr` attribute input --> $DIR/issue-43988.rs:24:5 | LL | #[repr] - | ^^^^^^^ help: must be of the form: `#[repr(C, packed, ...)]` + | ^^^^^^^ help: must be of the form: `#[repr(C)]` error: malformed `repr` attribute input --> $DIR/issue-43988.rs:35:14 | LL | let _z = #[repr] 1; - | ^^^^^^^ help: must be of the form: `#[repr(C, packed, ...)]` + | ^^^^^^^ help: must be of the form: `#[repr(C)]` error[E0518]: attribute should be applied to function or closure --> $DIR/issue-43988.rs:5:5 diff --git a/src/test/ui/repr.stderr b/src/test/ui/repr.stderr index e756510a437..e0bec666381 100644 --- a/src/test/ui/repr.stderr +++ b/src/test/ui/repr.stderr @@ -2,19 +2,19 @@ error: malformed `repr` attribute input --> $DIR/repr.rs:1:1 | LL | #[repr] - | ^^^^^^^ help: must be of the form: `#[repr(C, packed, ...)]` + | ^^^^^^^ help: must be of the form: `#[repr(C)]` error: malformed `repr` attribute input --> $DIR/repr.rs:4:1 | LL | #[repr = "B"] - | ^^^^^^^^^^^^^ help: must be of the form: `#[repr(C, packed, ...)]` + | ^^^^^^^^^^^^^ help: must be of the form: `#[repr(C)]` error: malformed `repr` attribute input --> $DIR/repr.rs:7:1 | LL | #[repr = "C"] - | ^^^^^^^^^^^^^ help: must be of the form: `#[repr(C, packed, ...)]` + | ^^^^^^^^^^^^^ help: must be of the form: `#[repr(C)]` error: aborting due to 3 previous errors |