about summary refs log tree commit diff
diff options
context:
space:
mode:
authorlongfangsong <longfangsong@icloud.com>2021-10-06 10:14:12 +0800
committerlongfangsong <longfangsong@icloud.com>2021-10-06 10:14:12 +0800
commit3fde682bcfda4d2dc435330c9f0733b90d7c54c6 (patch)
tree2f77164e6fbcfc84a984e19173ebabcde16c97f0
parent7228dbadcaf0d97b0da421127e703d921b2bce53 (diff)
downloadrust-3fde682bcfda4d2dc435330c9f0733b90d7c54c6.tar.gz
rust-3fde682bcfda4d2dc435330c9f0733b90d7c54c6.zip
cleanup
-rw-r--r--crates/ide_assists/src/handlers/generate_constant.rs13
1 files changed, 2 insertions, 11 deletions
diff --git a/crates/ide_assists/src/handlers/generate_constant.rs b/crates/ide_assists/src/handlers/generate_constant.rs
index 5332484f49c..52ae60e2edf 100644
--- a/crates/ide_assists/src/handlers/generate_constant.rs
+++ b/crates/ide_assists/src/handlers/generate_constant.rs
@@ -39,9 +39,6 @@ pub(crate) fn generate_constant(acc: &mut Assists, ctx: &AssistContext) -> Optio
     let module = scope.module()?;
     let type_name = ty.original().display_source_code(ctx.db(), module.into()).ok()?;
     let indent = IndentLevel::from_node(statement.syntax());
-    if !arg_list.syntax().text_range().contains_range(constant_token.syntax().text_range()) {
-        return None;
-    }
     if constant_token.to_string().chars().any(|it| !(it.is_uppercase() || it == '_')) {
         cov_mark::hit!(not_constant_name);
         return None;
@@ -51,20 +48,14 @@ pub(crate) fn generate_constant(acc: &mut Assists, ctx: &AssistContext) -> Optio
         return None;
     }
     let target = statement.syntax().parent()?.text_range();
-    let statement_syntax = statement.syntax().clone_for_update();
     acc.add(
         AssistId("generate_constant", AssistKind::QuickFix),
         "Generate constant",
         target,
         |builder| {
             builder.insert(
-                statement.syntax().text_range.start(),
-                format!(
-                    "const {}: {} = $0;\n{}",
-                    constant_token,
-                    type_name,
-                    indent
-                ),
+                statement.syntax().text_range().start(),
+                format!("const {}: {} = $0;\n{}", constant_token, type_name, indent),
             );
         },
     )