about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJonas Schievink <jonasschievink@gmail.com>2021-02-15 16:07:02 +0100
committerGitHub <noreply@github.com>2021-02-15 16:07:02 +0100
commit40d85a5f7d102d0ffba6abb5ca22df47e8778d7d (patch)
tree6f5cf02f3160801ff162d5ba7b24ab1375463f41
parentdb5ae6a6265e12e50f6e3002e37d72d06f46b3b7 (diff)
parentc58386012623d6f3940f28451d2e7088bce6ae58 (diff)
downloadrust-40d85a5f7d102d0ffba6abb5ca22df47e8778d7d.tar.gz
rust-40d85a5f7d102d0ffba6abb5ca22df47e8778d7d.zip
Rollup merge of #82106 - jyn514:cleanup-bootstrap, r=Mark-Simulacrum
Remove unnecessary `Option` in `default_doc`

Previously, there were two different ways to encode the same info: `None` or
`Some(&[])`. Now there is only one way, `&[]`.
-rw-r--r--src/bootstrap/builder.rs3
-rw-r--r--src/bootstrap/dist.rs4
-rw-r--r--src/bootstrap/test.rs2
3 files changed, 4 insertions, 5 deletions
diff --git a/src/bootstrap/builder.rs b/src/bootstrap/builder.rs
index 8fddd8cba08..a9099981e64 100644
--- a/src/bootstrap/builder.rs
+++ b/src/bootstrap/builder.rs
@@ -579,8 +579,7 @@ impl<'a> Builder<'a> {
         self.run_step_descriptions(&Builder::get_step_descriptions(self.kind), &self.paths);
     }
 
-    pub fn default_doc(&self, paths: Option<&[PathBuf]>) {
-        let paths = paths.unwrap_or(&[]);
+    pub fn default_doc(&self, paths: &[PathBuf]) {
         self.run_step_descriptions(&Builder::get_step_descriptions(Kind::Doc), paths);
     }
 
diff --git a/src/bootstrap/dist.rs b/src/bootstrap/dist.rs
index 3ebfdb24879..802b5c99500 100644
--- a/src/bootstrap/dist.rs
+++ b/src/bootstrap/dist.rs
@@ -68,7 +68,7 @@ impl Step for Docs {
         if !builder.config.docs {
             return None;
         }
-        builder.default_doc(None);
+        builder.default_doc(&[]);
 
         let dest = "share/doc/rust/html";
 
@@ -103,7 +103,7 @@ impl Step for RustcDocs {
         if !builder.config.compiler_docs {
             return None;
         }
-        builder.default_doc(None);
+        builder.default_doc(&[]);
 
         let mut tarball = Tarball::new(builder, "rustc-docs", &host.triple);
         tarball.set_product_name("Rustc Documentation");
diff --git a/src/bootstrap/test.rs b/src/bootstrap/test.rs
index d9132f20d85..7830dc82394 100644
--- a/src/bootstrap/test.rs
+++ b/src/bootstrap/test.rs
@@ -111,7 +111,7 @@ impl Step for Linkcheck {
 
         builder.info(&format!("Linkcheck ({})", host));
 
-        builder.default_doc(None);
+        builder.default_doc(&[]);
 
         let _time = util::timeit(&builder);
         try_run(