diff options
| author | Mazdak Farrokhzad <twingoow@gmail.com> | 2020-03-10 06:47:55 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-03-10 06:47:55 +0100 |
| commit | 436f2ec58cecdba7b03a05d89a90e6bce1e13500 (patch) | |
| tree | 56fef9d057cfc9f7f93aece0d55a9050605249ff | |
| parent | 08095f4978b1dbf1aba584969e314a3caac705a2 (diff) | |
| parent | d32924f89d1324386588bd23b0437cdeca1e0fc8 (diff) | |
| download | rust-436f2ec58cecdba7b03a05d89a90e6bce1e13500.tar.gz rust-436f2ec58cecdba7b03a05d89a90e6bce1e13500.zip | |
Rollup merge of #69836 - JohnTitor:immediate-outputs, r=nagisa
Check if output is immediate value Fixes #62046 r? @nagisa
| -rw-r--r-- | src/librustc_codegen_llvm/asm.rs | 10 | ||||
| -rw-r--r-- | src/test/ui/asm/issue-62046.rs | 11 | ||||
| -rw-r--r-- | src/test/ui/asm/issue-62046.stderr | 11 |
3 files changed, 30 insertions, 2 deletions
diff --git a/src/librustc_codegen_llvm/asm.rs b/src/librustc_codegen_llvm/asm.rs index c8f0fe8c723..7975a70ab26 100644 --- a/src/librustc_codegen_llvm/asm.rs +++ b/src/librustc_codegen_llvm/asm.rs @@ -29,11 +29,17 @@ impl AsmBuilderMethods<'tcx> for Builder<'a, 'll, 'tcx> { let mut indirect_outputs = vec![]; for (i, (out, &place)) in ia.outputs.iter().zip(&outputs).enumerate() { if out.is_rw { - inputs.push(self.load_operand(place).immediate()); + let operand = self.load_operand(place); + if let OperandValue::Immediate(_) = operand.val { + inputs.push(operand.immediate()); + } ext_constraints.push(i.to_string()); } if out.is_indirect { - indirect_outputs.push(self.load_operand(place).immediate()); + let operand = self.load_operand(place); + if let OperandValue::Immediate(_) = operand.val { + indirect_outputs.push(operand.immediate()); + } } else { output_types.push(place.layout.llvm_type(self.cx())); } diff --git a/src/test/ui/asm/issue-62046.rs b/src/test/ui/asm/issue-62046.rs new file mode 100644 index 00000000000..105dadd5fd3 --- /dev/null +++ b/src/test/ui/asm/issue-62046.rs @@ -0,0 +1,11 @@ +// build-fail +// ignore-emscripten no asm! support + +#![feature(asm)] + +fn main() { + unsafe { + asm!("nop" : "+r"("r15")); + //~^ malformed inline assembly + } +} diff --git a/src/test/ui/asm/issue-62046.stderr b/src/test/ui/asm/issue-62046.stderr new file mode 100644 index 00000000000..a38a300548d --- /dev/null +++ b/src/test/ui/asm/issue-62046.stderr @@ -0,0 +1,11 @@ +error[E0668]: malformed inline assembly + --> $DIR/issue-62046.rs:8:9 + | +LL | asm!("nop" : "+r"("r15")); + | ^^^^^^^^^^^^^^^^^^^^^^^^^^ + | + = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info) + +error: aborting due to previous error + +For more information about this error, try `rustc --explain E0668`. |
