diff options
| author | koka <koka.code@gmail.com> | 2023-02-01 19:29:31 +0900 |
|---|---|---|
| committer | koka <koka.code@gmail.com> | 2023-02-01 19:29:31 +0900 |
| commit | 4931f4549bb8622f3588ba835f8eb2201e687059 (patch) | |
| tree | 0d2d25149755abafbb078cc68287939c3d5b46de | |
| parent | a408e76098acc353d18ae43b0f02485954d80d5d (diff) | |
| download | rust-4931f4549bb8622f3588ba835f8eb2201e687059.tar.gz rust-4931f4549bb8622f3588ba835f8eb2201e687059.zip | |
Split if conditions by its semantics
| -rw-r--r-- | clippy_lints/src/manual_let_else.rs | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/clippy_lints/src/manual_let_else.rs b/clippy_lints/src/manual_let_else.rs index 4d53a664fa0..e461e538b5a 100644 --- a/clippy_lints/src/manual_let_else.rs +++ b/clippy_lints/src/manual_let_else.rs @@ -68,9 +68,11 @@ impl_lint_pass!(ManualLetElse => [MANUAL_LET_ELSE]); impl<'tcx> LateLintPass<'tcx> for ManualLetElse { fn check_stmt(&mut self, cx: &LateContext<'_>, stmt: &'tcx Stmt<'tcx>) { - if self.msrv.meets(msrvs::LET_ELSE) && - !in_external_macro(cx.sess(), stmt.span) && - let StmtKind::Local(local) = stmt.kind && + if !self.msrv.meets(msrvs::LET_ELSE) || in_external_macro(cx.sess(), stmt.span) { + return; + } + + if let StmtKind::Local(local) = stmt.kind && let Some(init) = local.init && local.els.is_none() && local.ty.is_none() && |