diff options
| author | Guillaume Gomez <guillaume1.gomez@gmail.com> | 2024-11-18 17:17:43 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-11-18 17:17:43 +0100 |
| commit | 4baf540fce6ad72df7787cc1f26859795de08d6f (patch) | |
| tree | c938e85c6828ee0dd2709a7cfe6be30ab706055e | |
| parent | 86ba13ba2fa230fa970932529e5044ba77c090a3 (diff) | |
| parent | dff98a8a144f7ebf19d8d238aed8f0e2c2375086 (diff) | |
| download | rust-4baf540fce6ad72df7787cc1f26859795de08d6f.tar.gz rust-4baf540fce6ad72df7787cc1f26859795de08d6f.zip | |
Rollup merge of #133163 - RalfJung:cold, r=saethlin
remove pointless cold_path impl in interpreter This has a fallback impl so the interpreter impl is not needed. r? ``@saethlin``
| -rw-r--r-- | compiler/rustc_codegen_cranelift/src/intrinsics/mod.rs | 1 | ||||
| -rw-r--r-- | compiler/rustc_const_eval/src/interpret/intrinsics.rs | 3 |
2 files changed, 1 insertions, 3 deletions
diff --git a/compiler/rustc_codegen_cranelift/src/intrinsics/mod.rs b/compiler/rustc_codegen_cranelift/src/intrinsics/mod.rs index b92885cc1a7..6cf1cff183d 100644 --- a/compiler/rustc_codegen_cranelift/src/intrinsics/mod.rs +++ b/compiler/rustc_codegen_cranelift/src/intrinsics/mod.rs @@ -1264,6 +1264,7 @@ fn codegen_regular_intrinsic_call<'tcx>( sym::cold_path => { // This is a no-op. The intrinsic is just a hint to the optimizer. + // We still have an impl here to avoid it being turned into a call. } // Unimplemented intrinsics must have a fallback body. The fallback body is obtained diff --git a/compiler/rustc_const_eval/src/interpret/intrinsics.rs b/compiler/rustc_const_eval/src/interpret/intrinsics.rs index d89d73824aa..c7a56a80e81 100644 --- a/compiler/rustc_const_eval/src/interpret/intrinsics.rs +++ b/compiler/rustc_const_eval/src/interpret/intrinsics.rs @@ -417,9 +417,6 @@ impl<'tcx, M: Machine<'tcx>> InterpCx<'tcx, M> { // These just return their argument self.copy_op(&args[0], dest)?; } - sym::cold_path => { - // This is a no-op. The intrinsic is just a hint to the optimizer. - } sym::raw_eq => { let result = self.raw_eq_intrinsic(&args[0], &args[1])?; self.write_scalar(result, dest)?; |
