diff options
| author | lcnr <rust@lcnr.de> | 2022-02-01 10:29:36 +0100 |
|---|---|---|
| committer | lcnr <rust@lcnr.de> | 2022-02-01 10:29:36 +0100 |
| commit | 4bbe970673e8b982e2c94d17cd860c2c89ca5211 (patch) | |
| tree | 89bb4e528a815e3087b5ff244e9eb819368e672b | |
| parent | 6970547d40108ba87cc64425c54c91a6caaebc5a (diff) | |
| download | rust-4bbe970673e8b982e2c94d17cd860c2c89ca5211.tar.gz rust-4bbe970673e8b982e2c94d17cd860c2c89ca5211.zip | |
review + rebase
| -rw-r--r-- | compiler/rustc_lint/src/internal.rs | 7 | ||||
| -rw-r--r-- | compiler/rustc_passes/src/check_attr.rs | 4 |
2 files changed, 6 insertions, 5 deletions
diff --git a/compiler/rustc_lint/src/internal.rs b/compiler/rustc_lint/src/internal.rs index 594251d46b4..fa8cbeaaf51 100644 --- a/compiler/rustc_lint/src/internal.rs +++ b/compiler/rustc_lint/src/internal.rs @@ -5,7 +5,8 @@ use crate::{EarlyContext, EarlyLintPass, LateContext, LateLintPass, LintContext} use rustc_ast as ast; use rustc_errors::Applicability; use rustc_hir::def::Res; -use rustc_hir::*; +use rustc_hir::{Expr, ExprKind, GenericArg, Path, PathSegment, QPath}; +use rustc_hir::{HirId, Item, ItemKind, Node, Ty, TyKind}; use rustc_middle::ty; use rustc_session::{declare_lint_pass, declare_tool_lint}; use rustc_span::hygiene::{ExpnKind, MacroKind}; @@ -75,10 +76,10 @@ impl LateLintPass<'_> for QueryStability { } let (span, def_id, substs) = match expr.kind { - ExprKind::MethodCall(_, span, _, _) + ExprKind::MethodCall(segment, _, _) if let Some(def_id) = cx.typeck_results().type_dependent_def_id(expr.hir_id) => { - (span, def_id, cx.typeck_results().node_substs(expr.hir_id)) + (segment.ident.span, def_id, cx.typeck_results().node_substs(expr.hir_id)) }, _ => { let &ty::FnDef(def_id, substs) = diff --git a/compiler/rustc_passes/src/check_attr.rs b/compiler/rustc_passes/src/check_attr.rs index 50d2c64ae78..ca511f7b814 100644 --- a/compiler/rustc_passes/src/check_attr.rs +++ b/compiler/rustc_passes/src/check_attr.rs @@ -487,7 +487,7 @@ impl CheckAttrVisitor<'_> { fn check_rustc_must_implement_one_of( &self, attr: &Attribute, - span: &Span, + span: Span, target: Target, ) -> bool { match target { @@ -496,7 +496,7 @@ impl CheckAttrVisitor<'_> { self.tcx .sess .struct_span_err(attr.span, "attribute can only be applied to a trait") - .span_label(*span, "not a trait") + .span_label(span, "not a trait") .emit(); false } |
