diff options
| author | Nick Cameron <ncameron@mozilla.com> | 2015-01-08 15:07:15 +1300 |
|---|---|---|
| committer | Nick Cameron <ncameron@mozilla.com> | 2015-01-08 15:43:00 +1300 |
| commit | 4d98cbb3f3692c1fd53cd27a45a9bb1e813be942 (patch) | |
| tree | ca2ab8aa56f410ee33510bea12b02039b008dbf8 | |
| parent | 9f1ead8fadc56bad30dc74f5cc50d78af4fbc972 (diff) | |
| download | rust-4d98cbb3f3692c1fd53cd27a45a9bb1e813be942.tar.gz rust-4d98cbb3f3692c1fd53cd27a45a9bb1e813be942.zip | |
Forbid associated items in inherent impls
Closes #20359
| -rw-r--r-- | src/librustc_typeck/collect.rs | 5 | ||||
| -rw-r--r-- | src/test/compile-fail/assoc-inherent.rs | 19 |
2 files changed, 24 insertions, 0 deletions
diff --git a/src/librustc_typeck/collect.rs b/src/librustc_typeck/collect.rs index 79e98f15a2d..5852a34560c 100644 --- a/src/librustc_typeck/collect.rs +++ b/src/librustc_typeck/collect.rs @@ -607,6 +607,11 @@ fn convert(ccx: &CollectCtxt, it: &ast::Item) { methods.push(&**method); } ast::TypeImplItem(ref typedef) => { + if opt_trait_ref.is_none() { + tcx.sess.span_err(typedef.span, + "associated items are not allowed in inherent impls"); + } + let typ = ccx.to_ty(&ExplicitRscope, &*typedef.typ); tcx.tcache .borrow_mut() diff --git a/src/test/compile-fail/assoc-inherent.rs b/src/test/compile-fail/assoc-inherent.rs new file mode 100644 index 00000000000..8025011bfa7 --- /dev/null +++ b/src/test/compile-fail/assoc-inherent.rs @@ -0,0 +1,19 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or +// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license +// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// Test associated types are forbidden in inherant impls. + +struct Foo; + +impl Foo { + type Bar = int; //~ERROR associated items are not allowed in inherent impls +} + +fn main() {} |
