about summary refs log tree commit diff
diff options
context:
space:
mode:
authorOli Scherer <github35764891676564198441@oli-obk.de>2021-08-20 13:56:54 +0000
committerOli Scherer <git-spam-no-reply9815368754983@oli-obk.de>2022-02-02 15:40:10 +0000
commit4e1a5968f13b19f16b88a52de1aa9fade94d469a (patch)
tree0b595caac413144b628f7ad429b7f3fdef8bf1d3
parentbbbdcb327f49274cf48a3d010c715dcdc3999d81 (diff)
downloadrust-4e1a5968f13b19f16b88a52de1aa9fade94d469a.tar.gz
rust-4e1a5968f13b19f16b88a52de1aa9fade94d469a.zip
Found suspicious comparison of constants
-rw-r--r--compiler/rustc_borrowck/src/type_check/relate_tys.rs3
1 files changed, 3 insertions, 0 deletions
diff --git a/compiler/rustc_borrowck/src/type_check/relate_tys.rs b/compiler/rustc_borrowck/src/type_check/relate_tys.rs
index cc3fe0a123c..0b5171680ad 100644
--- a/compiler/rustc_borrowck/src/type_check/relate_tys.rs
+++ b/compiler/rustc_borrowck/src/type_check/relate_tys.rs
@@ -117,6 +117,9 @@ impl<'tcx> TypeRelatingDelegate<'tcx> for NllTypeRelatingDelegate<'_, '_, 'tcx>
 
     // We don't have to worry about the equality of consts during borrow checking
     // as consts always have a static lifetime.
+    // FIXME(oli-obk): is this really true? We can at least have HKL and with
+    // inline consts we may have further lifetimes that may be unsound to treat as
+    // 'static.
     fn const_equate(&mut self, _a: &'tcx Const<'tcx>, _b: &'tcx Const<'tcx>) {}
 
     fn normalization() -> NormalizationStrategy {