diff options
| author | lucarlig <luca.carlig@huawei.com> | 2024-02-25 23:17:03 +0400 |
|---|---|---|
| committer | lucarlig <luca.carlig@huawei.com> | 2024-02-25 23:17:03 +0400 |
| commit | 5152050c5f8d1aa18f43b32dad5f1364ecb859a5 (patch) | |
| tree | 99fdbf7cbd0b16ad25ddbf91b5b67a522126c951 | |
| parent | ee50d5df90dc6cdeb266bf0965daf14799e0977b (diff) | |
| download | rust-5152050c5f8d1aa18f43b32dad5f1364ecb859a5.tar.gz rust-5152050c5f8d1aa18f43b32dad5f1364ecb859a5.zip | |
move lint directly into check_attrs
| -rw-r--r-- | clippy_lints/src/doc/empty_docs.rs | 20 | ||||
| -rw-r--r-- | clippy_lints/src/doc/mod.rs | 15 |
2 files changed, 12 insertions, 23 deletions
diff --git a/clippy_lints/src/doc/empty_docs.rs b/clippy_lints/src/doc/empty_docs.rs deleted file mode 100644 index 84cbc3207f3..00000000000 --- a/clippy_lints/src/doc/empty_docs.rs +++ /dev/null @@ -1,20 +0,0 @@ -use super::EMPTY_DOCS; -use clippy_utils::diagnostics::span_lint_and_help; -use rustc_ast::Attribute; -use rustc_lint::LateContext; -use rustc_resolve::rustdoc::{attrs_to_doc_fragments, span_of_fragments}; - -// TODO: Adjust the parameters as necessary -pub(super) fn check(cx: &LateContext<'_>, attrs: &[Attribute]) { - let (fragments, _) = attrs_to_doc_fragments(attrs.iter().map(|attr| (attr, None)), true); - if let Some(span) = span_of_fragments(&fragments) { - span_lint_and_help( - cx, - EMPTY_DOCS, - span, - "empty doc comment", - None, - "consider removing or filling it", - ); - } -} diff --git a/clippy_lints/src/doc/mod.rs b/clippy_lints/src/doc/mod.rs index 76fd900bff3..4a253e9fd6c 100644 --- a/clippy_lints/src/doc/mod.rs +++ b/clippy_lints/src/doc/mod.rs @@ -19,7 +19,8 @@ use rustc_middle::hir::nested_filter; use rustc_middle::lint::in_external_macro; use rustc_middle::ty::{self}; use rustc_resolve::rustdoc::{ - add_doc_fragment, attrs_to_doc_fragments, main_body_opts, source_span_for_markdown_range, DocFragment, + add_doc_fragment, attrs_to_doc_fragments, main_body_opts, source_span_for_markdown_range, span_of_fragments, + DocFragment, }; use rustc_session::impl_lint_pass; use rustc_span::edition::Edition; @@ -27,7 +28,6 @@ use rustc_span::{sym, Span}; use std::ops::Range; use url::Url; -mod empty_docs; mod link_with_quotes; mod markdown; mod missing_headers; @@ -546,7 +546,16 @@ fn check_attrs(cx: &LateContext<'_>, valid_idents: &FxHashSet<String>, attrs: &[ doc.pop(); if doc.trim().is_empty() { - empty_docs::check(cx, attrs); + if let Some(span) = span_of_fragments(&fragments) { + span_lint_and_help( + cx, + EMPTY_DOCS, + span, + "empty doc comment", + None, + "consider removing or filling it", + ); + } return Some(DocHeaders::default()); } |
