about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2018-05-29 17:17:53 +0000
committerbors <bors@rust-lang.org>2018-05-29 17:17:53 +0000
commit524ad9b9e03656f3fdeb03ed82fe78db3916e566 (patch)
treeaf3daa719c3edbef93d2dfb59240aec4fde044c6
parent59c0f5913ddc2f66c1ff8ab612f7027e38c85a6d (diff)
parent5067d2f133a2a5be4b39cea37d110bfa10c0ea6c (diff)
downloadrust-524ad9b9e03656f3fdeb03ed82fe78db3916e566.tar.gz
rust-524ad9b9e03656f3fdeb03ed82fe78db3916e566.zip
Auto merge of #51165 - SimonSapin:opt2, r=alexcrichton
Revert "Set opt-level to 3"

This reverts commit aad9840ad49c56830384e87bc8bd87fd0199dc44.

Level 3 (possibly indirectly, the underlying bug might be in XCode’s linker) causes unit tests to sefault when compiled with some versions of XCode: https://github.com/rust-lang/rust/issues/50867

It also appears to cause some segfaults on Windows: https://github.com/rust-lang/rust/pull/50329#issuecomment-386853473, and regressions in some rustc performance benchmarks: https://github.com/rust-lang/rust/pull/50329#issuecomment-388084894
-rw-r--r--src/Cargo.toml7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/Cargo.toml b/src/Cargo.toml
index 7504b43e20c..8ce4c97601b 100644
--- a/src/Cargo.toml
+++ b/src/Cargo.toml
@@ -40,6 +40,13 @@ members = [
   "tools/rls/test_data/workspace_symbol",
 ]
 
+# Curiously, libtest will segfault if compiled with opt-level=3
+# with some versions of XCode: https://github.com/rust-lang/rust/issues/50867
+[profile.release]
+opt-level = 2
+[profile.bench]
+opt-level = 2
+
 # These options are controlled from our rustc wrapper script, so turn them off
 # here and have them controlled elsewhere.
 [profile.dev]