about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJubilee <workingjubilee@gmail.com>2025-06-13 20:59:22 -0700
committerGitHub <noreply@github.com>2025-06-13 20:59:22 -0700
commit52894f96989c621ee2fc568038993643be4a4e97 (patch)
treeecdb4ecbba81ae523c59fce3ef1884ab81ad06e2
parent8effd40c4e4ce7704787ea681285204d85d9869c (diff)
parent764e97c86b47ef4b3c2f085982342b456b4bc2bc (diff)
downloadrust-52894f96989c621ee2fc568038993643be4a4e97.tar.gz
rust-52894f96989c621ee2fc568038993643be4a4e97.zip
Rollup merge of #142461 - Enselic:no-capture-tip, r=jieyouxu
compiletest: Clarify that `--no-capture` is needed with `--verbose`

Confusingly, this does not make compile test print what command is used to run a ui test:

    ./x test tests/ui/panics/abort-on-panic.rs --verbose

It is also necessary to pass `--no-capture`, like this:

    ./x test tests/ui/panics/abort-on-panic.rs --verbose --no-capture

Then you will see prints like this:

    executing cd "/rust/build/x86_64-unknown-linux-gnu/test/ui/panics/abort-on-panic.next" && \
        RUSTC="/rust/build/x86_64-unknown-linux-gnu/stage1/bin/rustc" \
        RUST_TEST_THREADS="32" \
        "/rust/build/x86_64-unknown-linux-gnu/test/ui/panics/abort-on-panic.next/a"

Add a hint in the code for this that would have helped me figure this out.

(See https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/compiltest.20show.20rustc.20commands.3F for some more context.)
-rw-r--r--src/tools/compiletest/src/util.rs1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/tools/compiletest/src/util.rs b/src/tools/compiletest/src/util.rs
index 81f5679aead..202582bea8c 100644
--- a/src/tools/compiletest/src/util.rs
+++ b/src/tools/compiletest/src/util.rs
@@ -29,6 +29,7 @@ fn path_div() -> &'static str {
 pub fn logv(config: &Config, s: String) {
     debug!("{}", s);
     if config.verbose {
+        // Note: `./x test ... --verbose --no-capture` is needed to see this print.
         println!("{}", s);
     }
 }