about summary refs log tree commit diff
diff options
context:
space:
mode:
authorVitaly _Vi Shukela <vi0oss@gmail.com>2018-09-18 22:43:52 +0300
committerflip1995 <9744647+flip1995@users.noreply.github.com>2018-09-20 14:38:48 +0200
commit52fb7d461ea231310de16e721e3b850747f5cf41 (patch)
tree883bd056827a9572d1ac611a03c632018306c284
parent58729346bed9f7c15c461665202fab5b7ec628c8 (diff)
downloadrust-52fb7d461ea231310de16e721e3b850747f5cf41.tar.gz
rust-52fb7d461ea231310de16e721e3b850747f5cf41.zip
Applicability adjustment per additional comments
-rw-r--r--clippy_lints/src/large_enum_variant.rs2
-rw-r--r--clippy_lints/src/let_if_seq.rs2
-rw-r--r--clippy_lints/src/matches.rs2
3 files changed, 3 insertions, 3 deletions
diff --git a/clippy_lints/src/large_enum_variant.rs b/clippy_lints/src/large_enum_variant.rs
index c346585250a..8ff53e15c31 100644
--- a/clippy_lints/src/large_enum_variant.rs
+++ b/clippy_lints/src/large_enum_variant.rs
@@ -102,7 +102,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for LargeEnumVariant {
                                         "consider boxing the large fields to reduce the total size of the \
                                          enum",
                                         format!("Box<{}>", snip),
-                                        Applicability::MachineApplicable,
+                                        Applicability::Unspecified,
                                     );
                                     return;
                                 }
diff --git a/clippy_lints/src/let_if_seq.rs b/clippy_lints/src/let_if_seq.rs
index ede55ce3721..53d13407be3 100644
--- a/clippy_lints/src/let_if_seq.rs
+++ b/clippy_lints/src/let_if_seq.rs
@@ -125,7 +125,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for LetIfSeq {
                                                 span,
                                                 "it is more idiomatic to write",
                                                 sug,
-                                                Applicability::MaybeIncorrect,
+                                                Applicability::HasPlaceholders,
                                             );
                                            if !mutability.is_empty() {
                                                db.note("you might not need `mut` at all");
diff --git a/clippy_lints/src/matches.rs b/clippy_lints/src/matches.rs
index 4c99aeae199..c1a65e756a9 100644
--- a/clippy_lints/src/matches.rs
+++ b/clippy_lints/src/matches.rs
@@ -344,7 +344,7 @@ fn check_match_bool(cx: &LateContext<'_, '_>, ex: &Expr, arms: &[Arm], expr: &Ex
                                 expr.span,
                                 "consider using an if/else expression",
                                 sugg,
-                                Applicability::MaybeIncorrect, // not sure
+                                Applicability::HasPlaceholders,
                             );
                         }
                     }