diff options
| author | Oli Scherer <git-spam-no-reply9815368754983@oli-obk.de> | 2023-03-15 16:25:28 +0000 |
|---|---|---|
| committer | Oli Scherer <git-spam-no-reply9815368754983@oli-obk.de> | 2023-04-04 09:01:44 +0000 |
| commit | 54214c8d8d50c76fa66e1411fbbbd17bf314bcb5 (patch) | |
| tree | 7bfbedf8fd640a37b2ca4a5c2b6d3221b57acf87 | |
| parent | 300901b70509a0af2d971aa6f6104300da24212c (diff) | |
| download | rust-54214c8d8d50c76fa66e1411fbbbd17bf314bcb5.tar.gz rust-54214c8d8d50c76fa66e1411fbbbd17bf314bcb5.zip | |
Use a simpler atomic operation than the `compare_exchange` hammer
| -rw-r--r-- | compiler/rustc_data_structures/src/sync.rs | 8 | ||||
| -rw-r--r-- | compiler/rustc_parse/src/parser/mod.rs | 4 |
2 files changed, 9 insertions, 3 deletions
diff --git a/compiler/rustc_data_structures/src/sync.rs b/compiler/rustc_data_structures/src/sync.rs index 80a9ccd6daa..e8ee4fb76cc 100644 --- a/compiler/rustc_data_structures/src/sync.rs +++ b/compiler/rustc_data_structures/src/sync.rs @@ -107,6 +107,14 @@ cfg_if! { } } + impl Atomic<bool> { + pub fn fetch_or(&self, val: bool, _: Ordering) -> bool { + let result = self.0.get() | val; + self.0.set(val); + result + } + } + impl<T: Copy + PartialEq> Atomic<T> { #[inline] pub fn compare_exchange(&self, diff --git a/compiler/rustc_parse/src/parser/mod.rs b/compiler/rustc_parse/src/parser/mod.rs index cc7270e7c2a..aa57b804779 100644 --- a/compiler/rustc_parse/src/parser/mod.rs +++ b/compiler/rustc_parse/src/parser/mod.rs @@ -1541,11 +1541,9 @@ pub(crate) fn make_unclosed_delims_error( } pub fn emit_unclosed_delims(unclosed_delims: &mut Vec<UnmatchedDelim>, sess: &ParseSess) { - let _ = sess.reached_eof.compare_exchange( - false, + let _ = sess.reached_eof.fetch_or( unclosed_delims.iter().any(|unmatched_delim| unmatched_delim.found_delim.is_none()), Ordering::Relaxed, - Ordering::Relaxed, ); for unmatched in unclosed_delims.drain(..) { if let Some(mut e) = make_unclosed_delims_error(unmatched, sess) { |
