about summary refs log tree commit diff
diff options
context:
space:
mode:
authorChayim Refael Friedman <chayimfr@gmail.com>2025-02-04 18:30:50 +0200
committerChayim Refael Friedman <chayimfr@gmail.com>2025-02-04 18:30:50 +0200
commit54670912dad92dcb7cc8fbc91f4ce1c3fc4cb49d (patch)
treebdbc79a44b57044ad3ead4914984b6c5cd77e398
parent1ba7a38e4f95cd7d8666719140650ce551bd1753 (diff)
downloadrust-54670912dad92dcb7cc8fbc91f4ce1c3fc4cb49d.tar.gz
rust-54670912dad92dcb7cc8fbc91f4ce1c3fc4cb49d.zip
Fix IDE resolution of `use` inside a body
We stopped the expression search too early because `use` is an item.
-rw-r--r--src/tools/rust-analyzer/crates/hir/src/source_analyzer.rs6
-rw-r--r--src/tools/rust-analyzer/crates/ide/src/goto_definition.rs18
2 files changed, 23 insertions, 1 deletions
diff --git a/src/tools/rust-analyzer/crates/hir/src/source_analyzer.rs b/src/tools/rust-analyzer/crates/hir/src/source_analyzer.rs
index ca239826d4f..23e7518883b 100644
--- a/src/tools/rust-analyzer/crates/hir/src/source_analyzer.rs
+++ b/src/tools/rust-analyzer/crates/hir/src/source_analyzer.rs
@@ -1252,7 +1252,11 @@ fn scope_for(
     node: InFile<&SyntaxNode>,
 ) -> Option<ScopeId> {
     node.ancestors_with_macros(db.upcast())
-        .take_while(|it| !ast::Item::can_cast(it.kind()) || ast::MacroCall::can_cast(it.kind()))
+        .take_while(|it| {
+            !ast::Item::can_cast(it.kind())
+                || ast::MacroCall::can_cast(it.kind())
+                || ast::Use::can_cast(it.kind())
+        })
         .filter_map(|it| it.map(ast::Expr::cast).transpose())
         .filter_map(|it| source_map.node_expr(it.as_ref())?.as_expr())
         .find_map(|it| scopes.scope_for(it))
diff --git a/src/tools/rust-analyzer/crates/ide/src/goto_definition.rs b/src/tools/rust-analyzer/crates/ide/src/goto_definition.rs
index 45f694d2fb6..bdafb701ff5 100644
--- a/src/tools/rust-analyzer/crates/ide/src/goto_definition.rs
+++ b/src/tools/rust-analyzer/crates/ide/src/goto_definition.rs
@@ -3272,4 +3272,22 @@ fn f() {
         "#,
         );
     }
+
+    #[test]
+    fn use_inside_body() {
+        check(
+            r#"
+fn main() {
+    mod nice_module {
+        pub(super) struct NiceStruct;
+                       // ^^^^^^^^^^
+    }
+
+    use nice_module::NiceStruct$0;
+
+    let _ = NiceStruct;
+}
+    "#,
+        );
+    }
 }