diff options
| author | Tim Chevalier <chevalier@alum.wellesley.edu> | 2013-07-13 13:38:07 -0700 |
|---|---|---|
| committer | Tim Chevalier <chevalier@alum.wellesley.edu> | 2013-07-13 13:48:55 -0700 |
| commit | 563172a73be64aa2b0f528346095aba566753d14 (patch) | |
| tree | e713a712cc4bc8a228d1c9989260f81e389f56a9 | |
| parent | 1a46afb3be3c12102d5c0e5ac7b3bb1debf207a0 (diff) | |
| download | rust-563172a73be64aa2b0f528346095aba566753d14.tar.gz rust-563172a73be64aa2b0f528346095aba566753d14.zip | |
rustpkg: Address review comments from cmr
| -rw-r--r-- | src/librustpkg/installed_packages.rs | 4 | ||||
| -rw-r--r-- | src/librustpkg/testsuite/pass/src/install-paths/main.rs | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/librustpkg/installed_packages.rs b/src/librustpkg/installed_packages.rs index 2716cc5d5b5..980b00d3864 100644 --- a/src/librustpkg/installed_packages.rs +++ b/src/librustpkg/installed_packages.rs @@ -15,7 +15,7 @@ use std::os; pub fn list_installed_packages(f: &fn(&PkgId) -> bool) -> bool { let workspaces = rust_path(); - for workspaces.iter().advance() |p| { + for workspaces.iter().advance |p| { let binfiles = os::list_dir(&p.push("bin")); for binfiles.iter().advance() |exec| { f(&PkgId::new(*exec)); @@ -30,7 +30,7 @@ pub fn list_installed_packages(f: &fn(&PkgId) -> bool) -> bool { pub fn package_is_installed(p: &PkgId) -> bool { let mut is_installed = false; - let _ = do list_installed_packages() |installed| { + do list_installed_packages() |installed| { if installed == p { is_installed = true; } diff --git a/src/librustpkg/testsuite/pass/src/install-paths/main.rs b/src/librustpkg/testsuite/pass/src/install-paths/main.rs index 3be03b6278b..431350c07b4 100644 --- a/src/librustpkg/testsuite/pass/src/install-paths/main.rs +++ b/src/librustpkg/testsuite/pass/src/install-paths/main.rs @@ -24,5 +24,5 @@ use lib::f; mod lib; fn main() { - let _ = f(); + f(); } |