about summary refs log tree commit diff
diff options
context:
space:
mode:
authorLzu Tao <taolzu@gmail.com>2019-09-26 01:53:39 +0000
committerLzu Tao <taolzu@gmail.com>2019-09-26 01:53:39 +0000
commit5639639d3530529d88b9e2ec5c9468f4fb7acec1 (patch)
treed985ab958297ca3dfebad9f14f1f35e07d30f52d
parent08ce6bc6d9532191e59a49786811a0735ea35f5a (diff)
downloadrust-5639639d3530529d88b9e2ec5c9468f4fb7acec1.tar.gz
rust-5639639d3530529d88b9e2ec5c9468f4fb7acec1.zip
Remove unused attribute in test
-rw-r--r--tests/ui/toplevel_ref_arg.fixed13
-rw-r--r--tests/ui/toplevel_ref_arg.rs13
-rw-r--r--tests/ui/toplevel_ref_arg.stderr30
3 files changed, 27 insertions, 29 deletions
diff --git a/tests/ui/toplevel_ref_arg.fixed b/tests/ui/toplevel_ref_arg.fixed
index df3c15ed59e..9438abbe330 100644
--- a/tests/ui/toplevel_ref_arg.fixed
+++ b/tests/ui/toplevel_ref_arg.fixed
@@ -1,27 +1,26 @@
 // run-rustfix
 
 #![warn(clippy::toplevel_ref_arg)]
-#![allow(unused)]
 
 fn main() {
     // Closures should not warn
     let y = |ref x| println!("{:?}", x);
     y(1u8);
 
-    let x = &1;
+    let _x = &1;
 
-    let y: &(&_, u8) = &(&1, 2);
+    let _y: &(&_, u8) = &(&1, 2);
 
-    let z = &(1 + 2);
+    let _z = &(1 + 2);
 
-    let z = &mut (1 + 2);
+    let _z = &mut (1 + 2);
 
     let (ref x, _) = (1, 2); // ok, not top level
     println!("The answer is {}.", x);
 
-    let x = &vec![1, 2, 3];
+    let _x = &vec![1, 2, 3];
 
     // Make sure that allowing the lint works
     #[allow(clippy::toplevel_ref_arg)]
-    let ref mut x = 1_234_543;
+    let ref mut _x = 1_234_543;
 }
diff --git a/tests/ui/toplevel_ref_arg.rs b/tests/ui/toplevel_ref_arg.rs
index e11c40966e4..ee630f12a60 100644
--- a/tests/ui/toplevel_ref_arg.rs
+++ b/tests/ui/toplevel_ref_arg.rs
@@ -1,27 +1,26 @@
 // run-rustfix
 
 #![warn(clippy::toplevel_ref_arg)]
-#![allow(unused)]
 
 fn main() {
     // Closures should not warn
     let y = |ref x| println!("{:?}", x);
     y(1u8);
 
-    let ref x = 1;
+    let ref _x = 1;
 
-    let ref y: (&_, u8) = (&1, 2);
+    let ref _y: (&_, u8) = (&1, 2);
 
-    let ref z = 1 + 2;
+    let ref _z = 1 + 2;
 
-    let ref mut z = 1 + 2;
+    let ref mut _z = 1 + 2;
 
     let (ref x, _) = (1, 2); // ok, not top level
     println!("The answer is {}.", x);
 
-    let ref x = vec![1, 2, 3];
+    let ref _x = vec![1, 2, 3];
 
     // Make sure that allowing the lint works
     #[allow(clippy::toplevel_ref_arg)]
-    let ref mut x = 1_234_543;
+    let ref mut _x = 1_234_543;
 }
diff --git a/tests/ui/toplevel_ref_arg.stderr b/tests/ui/toplevel_ref_arg.stderr
index 882e9e558b2..19d69496709 100644
--- a/tests/ui/toplevel_ref_arg.stderr
+++ b/tests/ui/toplevel_ref_arg.stderr
@@ -1,34 +1,34 @@
 error: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
-  --> $DIR/toplevel_ref_arg.rs:11:9
+  --> $DIR/toplevel_ref_arg.rs:10:9
    |
-LL |     let ref x = 1;
-   |     ----^^^^^----- help: try: `let x = &1;`
+LL |     let ref _x = 1;
+   |     ----^^^^^^----- help: try: `let _x = &1;`
    |
    = note: `-D clippy::toplevel-ref-arg` implied by `-D warnings`
 
 error: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
-  --> $DIR/toplevel_ref_arg.rs:13:9
+  --> $DIR/toplevel_ref_arg.rs:12:9
    |
-LL |     let ref y: (&_, u8) = (&1, 2);
-   |     ----^^^^^--------------------- help: try: `let y: &(&_, u8) = &(&1, 2);`
+LL |     let ref _y: (&_, u8) = (&1, 2);
+   |     ----^^^^^^--------------------- help: try: `let _y: &(&_, u8) = &(&1, 2);`
 
 error: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
-  --> $DIR/toplevel_ref_arg.rs:15:9
+  --> $DIR/toplevel_ref_arg.rs:14:9
    |
-LL |     let ref z = 1 + 2;
-   |     ----^^^^^--------- help: try: `let z = &(1 + 2);`
+LL |     let ref _z = 1 + 2;
+   |     ----^^^^^^--------- help: try: `let _z = &(1 + 2);`
 
 error: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
-  --> $DIR/toplevel_ref_arg.rs:17:9
+  --> $DIR/toplevel_ref_arg.rs:16:9
    |
-LL |     let ref mut z = 1 + 2;
-   |     ----^^^^^^^^^--------- help: try: `let z = &mut (1 + 2);`
+LL |     let ref mut _z = 1 + 2;
+   |     ----^^^^^^^^^^--------- help: try: `let _z = &mut (1 + 2);`
 
 error: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
-  --> $DIR/toplevel_ref_arg.rs:22:9
+  --> $DIR/toplevel_ref_arg.rs:21:9
    |
-LL |     let ref x = vec![1, 2, 3];
-   |     ----^^^^^----------------- help: try: `let x = &vec![1, 2, 3];`
+LL |     let ref _x = vec![1, 2, 3];
+   |     ----^^^^^^----------------- help: try: `let _x = &vec![1, 2, 3];`
 
 error: aborting due to 5 previous errors