about summary refs log tree commit diff
diff options
context:
space:
mode:
authorManish Goregaokar <manishsmail@gmail.com>2024-03-14 15:07:30 +0100
committerManish Goregaokar <manishsmail@gmail.com>2024-03-14 15:07:30 +0100
commit580e5b855d58d2076460b7a16c87e622b7d68960 (patch)
tree3eb0b2374cc25fbfe1536bde06beecc5ef7df374
parent26028209e808377d52ea36618b2cf2d75e0bcd6c (diff)
downloadrust-580e5b855d58d2076460b7a16c87e622b7d68960.tar.gz
rust-580e5b855d58d2076460b7a16c87e622b7d68960.zip
inline
-rw-r--r--src/librustdoc/html/format.rs14
1 files changed, 9 insertions, 5 deletions
diff --git a/src/librustdoc/html/format.rs b/src/librustdoc/html/format.rs
index 745001e035e..312765d3e6d 100644
--- a/src/librustdoc/html/format.rs
+++ b/src/librustdoc/html/format.rs
@@ -1509,8 +1509,6 @@ pub(crate) fn visibility_print_with_space<'a, 'tcx: 'a>(
     cx: &'a Context<'tcx>,
 ) -> impl Display + 'a + Captures<'tcx> {
     use std::fmt::Write as _;
-
-    let hidden: &'static str = if item.is_doc_hidden() { "#[doc(hidden)] " } else { "" };
     let vis: Cow<'static, str> = match item.visibility(cx.tcx()) {
         None => "".into(),
         Some(ty::Visibility::Public) => "pub ".into(),
@@ -1546,8 +1544,13 @@ pub(crate) fn visibility_print_with_space<'a, 'tcx: 'a>(
             }
         }
     };
+
+    let is_doc_hidden = item.is_doc_hidden();
     display_fn(move |f| {
-        f.write_str(&hidden)?;
+        if is_doc_hidden {
+            f.write_str("#[doc(hidden)] ")?;
+        }
+
         f.write_str(&vis)
     })
 }
@@ -1561,7 +1564,6 @@ pub(crate) fn visibility_to_src_with_space<'a, 'tcx: 'a>(
     item_did: DefId,
     is_doc_hidden: bool,
 ) -> impl Display + 'a + Captures<'tcx> {
-    let hidden: &'static str = if is_doc_hidden { "#[doc(hidden)] " } else { "" };
     let vis: Cow<'static, str> = match visibility {
         None => "".into(),
         Some(ty::Visibility::Public) => "pub ".into(),
@@ -1587,7 +1589,9 @@ pub(crate) fn visibility_to_src_with_space<'a, 'tcx: 'a>(
         }
     };
     display_fn(move |f| {
-        f.write_str(&hidden)?;
+        if is_doc_hidden {
+            f.write_str("#[doc(hidden)] ")?;
+        }
         f.write_str(&vis)
     })
 }