diff options
| author | Alex Crichton <alex@alexcrichton.com> | 2013-04-09 02:08:16 -0400 |
|---|---|---|
| committer | Alex Crichton <alex@alexcrichton.com> | 2013-04-14 01:15:46 -0400 |
| commit | 59e69aa0e79302887abcb4b6bf3613c84b48e5d7 (patch) | |
| tree | db56ecdc41dd9c89815e52ee6510a7e894f46bff | |
| parent | 8978643f92fc8780515d838a9797f9454386618b (diff) | |
| download | rust-59e69aa0e79302887abcb4b6bf3613c84b48e5d7.tar.gz rust-59e69aa0e79302887abcb4b6bf3613c84b48e5d7.zip | |
test: remove unnecessary unsafe blocks/functions
| -rw-r--r-- | src/compiletest/errors.rs | 52 | ||||
| -rw-r--r-- | src/compiletest/header.rs | 18 |
2 files changed, 33 insertions, 37 deletions
diff --git a/src/compiletest/errors.rs b/src/compiletest/errors.rs index 63b5c64c6d4..5a5c091d957 100644 --- a/src/compiletest/errors.rs +++ b/src/compiletest/errors.rs @@ -30,36 +30,34 @@ pub fn load_errors(testfile: &Path) -> ~[ExpectedError] { } fn parse_expected(line_num: uint, line: ~str) -> ~[ExpectedError] { - unsafe { - let error_tag = ~"//~"; - let mut idx; - match str::find_str(line, error_tag) { - None => return ~[], - Some(nn) => { idx = (nn as uint) + str::len(error_tag); } - } + let error_tag = ~"//~"; + let mut idx; + match str::find_str(line, error_tag) { + None => return ~[], + Some(nn) => { idx = (nn as uint) + str::len(error_tag); } + } - // "//~^^^ kind msg" denotes a message expected - // three lines above current line: - let mut adjust_line = 0u; - let len = str::len(line); - while idx < len && line[idx] == ('^' as u8) { - adjust_line += 1u; - idx += 1u; - } + // "//~^^^ kind msg" denotes a message expected + // three lines above current line: + let mut adjust_line = 0u; + let len = str::len(line); + while idx < len && line[idx] == ('^' as u8) { + adjust_line += 1u; + idx += 1u; + } - // Extract kind: - while idx < len && line[idx] == (' ' as u8) { idx += 1u; } - let start_kind = idx; - while idx < len && line[idx] != (' ' as u8) { idx += 1u; } - let kind = str::to_lower(str::slice(line, start_kind, idx).to_owned()); + // Extract kind: + while idx < len && line[idx] == (' ' as u8) { idx += 1u; } + let start_kind = idx; + while idx < len && line[idx] != (' ' as u8) { idx += 1u; } + let kind = str::to_lower(str::slice(line, start_kind, idx).to_owned()); - // Extract msg: - while idx < len && line[idx] == (' ' as u8) { idx += 1u; } - let msg = str::slice(line, idx, len).to_owned(); + // Extract msg: + while idx < len && line[idx] == (' ' as u8) { idx += 1u; } + let msg = str::slice(line, idx, len).to_owned(); - debug!("line=%u kind=%s msg=%s", line_num - adjust_line, kind, msg); + debug!("line=%u kind=%s msg=%s", line_num - adjust_line, kind, msg); - return ~[ExpectedError{line: line_num - adjust_line, kind: kind, - msg: msg}]; - } + return ~[ExpectedError{line: line_num - adjust_line, kind: kind, + msg: msg}]; } diff --git a/src/compiletest/header.rs b/src/compiletest/header.rs index 5a35c56c075..2b365188338 100644 --- a/src/compiletest/header.rs +++ b/src/compiletest/header.rs @@ -171,16 +171,14 @@ fn parse_name_directive(line: ~str, directive: ~str) -> bool { fn parse_name_value_directive(line: ~str, directive: ~str) -> Option<~str> { - unsafe { - let keycolon = directive + ~":"; - match str::find_str(line, keycolon) { - Some(colon) => { - let value = str::slice(line, colon + str::len(keycolon), - str::len(line)).to_owned(); - debug!("%s: %s", directive, value); - Some(value) - } - None => None + let keycolon = directive + ~":"; + match str::find_str(line, keycolon) { + Some(colon) => { + let value = str::slice(line, colon + str::len(keycolon), + str::len(line)).to_owned(); + debug!("%s: %s", directive, value); + Some(value) } + None => None } } |
