about summary refs log tree commit diff
diff options
context:
space:
mode:
authorTim Neumann <mail@timnn.me>2017-04-14 11:27:35 +0200
committerTim Neumann <mail@timnn.me>2017-04-23 22:00:02 +0200
commit5bd4e27db235bb857066e43384d483aa9dbdf56e (patch)
treee4e045bcd7d85d9fb2236d0c92c1dbff2bfa39b8
parent5ae4a58c339a935fd098ba6ea8315af444113276 (diff)
downloadrust-5bd4e27db235bb857066e43384d483aa9dbdf56e.tar.gz
rust-5bd4e27db235bb857066e43384d483aa9dbdf56e.zip
FIN: update appveyor mingw description
-rw-r--r--appveyor.yml21
1 files changed, 5 insertions, 16 deletions
diff --git a/appveyor.yml b/appveyor.yml
index 83cfea0dd83..450a489f0b1 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -20,28 +20,17 @@ environment:
 
   # 32/64-bit MinGW builds.
   #
-  # The MinGW builds unfortunately have to both download a custom toolchain and
-  # avoid the one installed by AppVeyor by default. Interestingly, though, for
-  # different reasons!
+  # We are using MinGW with posix threads since LLVM does not compile with
+  # the win32 threads version due to missing support for C++'s std::thread.
   #
-  # For 32-bit the installed gcc toolchain on AppVeyor uses the pthread
-  # threading model. This is unfortunately not what we want, and if we compile
-  # with it then there's lots of link errors in the standard library (undefined
-  # references to pthread symbols).
-  #
-  # For 64-bit the installed gcc toolchain is currently 5.3.0 which
-  # unfortunately segfaults on Windows with --enable-llvm-assertions (segfaults
-  # in LLVM). See rust-lang/rust#28445 for more information, but to work around
-  # this we go back in time to 4.9.2 specifically.
+  # Instead of relying on the MinGW version installed on appveryor we download
+  # and install one ourselves so we won't be surprised by changes to appveyor's
+  # build image.
   #
   # Finally, note that the downloads below are all in the `rust-lang-ci` S3
   # bucket, but they cleraly didn't originate there! The downloads originally
   # came from the mingw-w64 SourceForge download site. Unfortunately
   # SourceForge is notoriously flaky, so we mirror it on our own infrastructure.
-  #
-  # And as a final point of note, the 32-bit MinGW build using the makefiles do
-  # *not* use debug assertions and llvm assertions. This is because they take
-  # too long on appveyor and this is tested by rustbuild below.
   - MSYS_BITS: 32
     RUST_CONFIGURE_ARGS: --build=i686-pc-windows-gnu --enable-ninja
     SCRIPT: python x.py test